defaultStackFilter and/or tests need updating for causal async stacks

@Hixie

Trying to roll the engine, I see that a few tests are failing because the new causal async stacktraces include new frames the tests don't expect. There's a tension between the defaultStackFilter trying to reduce verbosity and causal async stack trying to provide context.

Sorry, that test is over testing. Feel free to change the test.

@abarth

Please feel free to change the test, as @abarth suggests, but I'd like to review the change before checkin.

Also, the stack trace in https://travis-ci.org/flutter/flutter/builds/201356918 is crazy, what is going on there?

For a program like

baz() async => throw "XYZ";
bar() async => await baz();
foo() async => await bar();
main() async => await foo();

the stack trace used to be

#0      baz.<baz_async_body> (file:///Users/rmacnak/dart1/sdk/a.dart:2:16)
#1      Future.Future.microtask.<anonymous closure> (dart:async/future.dart:184)
#2      _microtaskLoop (dart:async/schedule_microtask.dart:41)
#3      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#4      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)

but now is

#0      baz (file:///Users/rmacnak/dart1/sdk/a.dart:2:16)
<asynchronous suspension>
#1      bar (file:///Users/rmacnak/dart1/sdk/a.dart:3:22)
<asynchronous suspension>
#2      foo (file:///Users/rmacnak/dart1/sdk/a.dart:4:22)
<asynchronous suspension>
#3      main (file:///Users/rmacnak/dart1/sdk/a.dart:5:23)
<asynchronous suspension>
#4      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:261)
#5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

Roll engine to b64c887. (#8124)

@rmacnak-google

@rmacnak-google Can you clarify what needs changing here?

@rmacnak-google

@rmacnak-google since there hasn't been a response since 2017, I am going to close the issue. If this is still relevant, please reopen and provide more information.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

defaultStackFilter and/or tests need updating for causal async stacks #8128

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

defaultStackFilter and/or tests need updating for causal async stacks #8128

Description

Activity

abarth commented on Feb 14, 2017

Hixie commented on Feb 14, 2017

rmacnak-google commented on Feb 14, 2017

Hixie commented on Feb 28, 2017

zoeyfan commented on Jan 3, 2020

github-actions commented on Aug 8, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions