Skip to content

Roll engine to b64c88766dbd83bf4bab1cd1cd1757139b6cdb74. - #8124

Merged
goderbauer merged 2 commits into
flutter:masterfrom
rmacnak-google:roll
Feb 15, 2017
Merged

goderbauer merged 2 commits into
flutter:masterfrom
rmacnak-google:roll

Conversation

@rmacnak-google

Copy link
Copy Markdown
Contributor

Picks up changes to include inlined frames and line numbers in AOT stack traces.

Picks up changes to include inlined frames and line numbers in AOT stack traces.
@rmacnak-google
rmacnak-google requested a review from Hixie February 14, 2017 17:51
@goderbauer

Copy link
Copy Markdown
Member

LGTM

@goderbauer
goderbauer merged commit 15af4a0 into flutter:master Feb 15, 2017
@Hixie

Hixie commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

This had a notable impact on our release size benchmarks.

@Hixie

Hixie commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

Filed bug tracking the regressions at #8188.
Given the number of benchmarks regressed and the severity of some of the regressions (e.g. aot_snapshot_size_rodata almost doubled, increasing by around a megabyte, basic_material_app release_size_in_bytes increased in size by several hundred kilobytes), I recommend reverting this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants