Repository navigation
Regressions from recent engine roll #8188
Description
These regressions were a result of the engine roll in #8124.
The following size-related benchmarks all regressed, some substantially:
- basic_material_app__size: release_size_in_bytes
- basic_material_app_is__size: release_size_in_bytes
- complex_layout__build: aot_snapshot_size_instructions
- complex_layout__build: aot_snapshot_size_isolate
- complex_layout__build: aot_snapshot_size_rodata
- complex_layout__build: aot_snapshot_size_total
- flutter_gallery__build: aot_snapshot_size_isolate
- flutter_gallery__build: aot_snapshot_size_rodata
- flutter_gallery__build: aot_snapshot_size_total
The following performance microbenchmark regressed:
- microbenchmarks: velocity_tracker_iteration
cc @goderbauer
Activity
rmacnak-google commentedon Feb 15, 2017
@yjbanov
The snapshot size increases are expected. They are due to metadata for producing correct stack traces.
Cf. dart-lang/sdk@cfe5e5f
goderbauer commentedon Feb 15, 2017
With that, the only unexpected change is velocity_tracker_iteration (from ~2026ms to ~2160ms).
Hixie commentedon Feb 15, 2017
Current status:
@jason-simmons is looking at the perf regression.
@abarth and @rmacnak-google and I will discuss plans for binary size.
Hixie commentedon Feb 15, 2017
Looks like microbenchmarks_ios stock_layout_iteration also regressed.
jason-simmons commentedon Feb 17, 2017
Took a look at velocity_tracker_iteration but didn't reach any conclusion.
Doing some binary searching through Dart history, the earliest change that seems to correlate with this regression is 3f5458cdcba21e694645a1733036c1739106208b ([dart:io] Adds functions to set file access and modification time).
But there's no obvious connection between that change and performance of this benchmark, which isn't doing file IO.
Hixie commentedon Feb 17, 2017
Tracking the remaining issue in dart-lang/sdk#28785
github-actions commentedon Sep 5, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.