Skip to content

Merge dart:ui_internals into dart:ui #83

Closed
Closed
Merge dart:ui_internals into dart:ui#83
Assignees
abarth
Labels
c: API breakBackwards-incompatible API changesc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.

Description

@FlutterIssues
FlutterIssues
opened on Nov 9, 2015

Issue by Hixie
Thursday Jul 16, 2015 at 22:34 GMT
Originally opened as https://github.com/flutter/engine/issues/51

From @Hixie on June 18, 2015 19:55

We should move the "take*" functions from dart:internals to dart:sky.

While we're at it, we should probably remove contentAsText() and renderTreeAsText() (since those test obsolete features). This leaves only notifyTestComplete(), at which point we should rename dart:internals to dart:sky.testing or some such.

Copied from original issue: domokit/mojo#254

Activity

  1. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    FlutterIssues
    on Nov 9, 2015
    Author

    Comment by Hixie
    Thursday Jul 16, 2015 at 22:34 GMT

    We might want to rename dart:sky_builtin to dart:sky.internals then too.

  2. FlutterIssues
    added
    engineflutter/engine related. See also e: labels.
    c: new featureNothing broken; request for a new capability
    on Nov 9, 2015
  3. Hixie
    changed the title [-]Merge dart:sky.internals into dart:sky[/-] [+]Merge dart:ui_internals into dart:ui[/+] on Nov 11, 2015
  4. Hixie
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    and removed
    c: new featureNothing broken; request for a new capability
    on Dec 16, 2015
  5. Hixie
    added this to the milestone on Dec 16, 2015
  6. Hixie
    added
    c: API breakBackwards-incompatible API changes
    on Dec 16, 2015
  7. abarth
    self-assigned this
    on Feb 1, 2016

  8. abarth commented on Feb 13, 2016

    @abarth
    abarth
    on Feb 13, 2016
    Contributor

    flutter-team-archive/engine#2397

  9. abarth
    added a commit that references this issue on Feb 13, 2016

    Remove references to dart:ui_internals

    3d51d6a
  10. abarth
    closed this as completedon Feb 13, 2016
  11. abarth
    added a commit that references this issue on Feb 13, 2016

    Remove references to dart:ui_internals

    deb9d0b
  12. Letty-Liang
    added a commit that references this issue on Mar 21, 2019

    Recompile and relink the world on compiler updates. (flutter#83)

    6b9d76d

  13. github-actions commented on Aug 17, 2021

    @github-actions
    github-actionsbot
    on Aug 17, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. github-actions
    locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: API breakBackwards-incompatible API changesc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions