Devicelab bots should always upload full attached device log #84000

Activity

1. dnfield

   added

   infra: device doctorInfrastructure "device doctor" problemsInfrastructure "device doctor" problems

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   team: flakes

   team-infraOwned by Infrastructure teamOwned by Infrastructure team

   on Jun 4, 2021
2. dnfield

   self-assigned this

   on Jun 4, 2021
3. dnfield commented on Jun 4, 2021

   

   dnfield

   on Jun 4, 2021

   ContributorAuthor

   More actions

   @jmagman - I'd like to make flutter log work on iPhone's without observatory/lldb. From a local experiment, it looks like idevicesyslog works with an iOS 14.4.2 phone. Do you know what's up?

   flutter logs works for me locally if I remove

   flutter/packages/flutter_tools/lib/src/ios/devices.dart

   Lines 730 to 733 in 0acf53e

   	// syslog is not written on iOS 13+.
   	if (_majorSdkVersion >= minimumUniversalLoggingSdkVersion) {
   	return;
   	}
4. jmagman commented on Jun 4, 2021

   

   jmagman

   on Jun 4, 2021

   Member

   More actions

   For example, it should start adb logcat or idevicesyslog and dump that to something in the env['FLUTTER_LOGS_DIR'].

   The FLUTTER_LOGS_DIR logic is in:

   flutter/dev/devicelab/lib/framework/host_agent.dart

   Line 23 in e7b7ebc

   Directory get dumpDirectory {

   Currently used like:
   

   flutter/dev/devicelab/bin/tasks/module_test_ios.dart

   Lines 362 to 364 in 2d86249

   	await inDirectory(resultBundleTemp, () {
   	final String zipPath = path.join(hostAgent.dumpDirectory.path,
   	'module_test_ios-objc-${DateTime.now().toLocal().toIso8601String()}.zip');

   @jmagman - I'd like to make flutter log work on iPhone's without observatory/lldb. From a local experiment, it looks like idevicesyslog works with an iOS 14.4.2 phone. Do you know what's up?

   flutter logs works for me locally if I remove

   flutter/packages/flutter_tools/lib/src/ios/devices.dart

   Lines 730 to 733 in 0acf53e

   	// syslog is not written on iOS 13+.
   	if (_majorSdkVersion >= minimumUniversalLoggingSdkVersion) {
   	return;
   	}

   It would be awesome to get flutter logs working again #44199. However, we shouldn't remove the lldb attaching/log parsing that was added to workaround the loss of those logs since it let us remove all the mDNS port discovery reliance for run and drive (see #66399 for details). Using idevicesyslog again for logs and attach would be great.

   👍React with 👍1Reacted by Dan Field
5. dnfield commented on Jun 4, 2021

   

   dnfield

   on Jun 4, 2021

   ContributorAuthor

   More actions

   I'm not sure if using HostAgent is the right pattern for this, mainly because I want this to be done for all commands on CI, and optionally when doing a local run (we should't fill up dev machines with logs they can easily get themselves).

   WDYT?
6. dnfield

   closed this as completedin #84008on Jun 7, 2021
7. github-actions commented on Jul 31, 2021

   

   github-actionsbot

   on Jul 31, 2021

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
8. github-actions

   locked as resolved and limited conversation to collaborators on Jul 31, 2021
9. flutter-triage-bot

   added

   c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly pass

   on Jul 7, 2023