Skip to content

[web] binding_test 'defaultStackFilter elides framework Element mounting stacks' fails on the web #87875

Open

Description

@darrenaustin

Part of the skip test audit. The test:

testWidgets('defaultStackFilter elides framework Element mounting stacks', (WidgetTester tester) async {

Is currently skipped on the web. If we reenable it we get:

% flutter test --platform=chrome --web-renderer=html test/widgets/binding_test.dart 
00:02 +8: defaultStackFilter elides framework Element mounting stacks                                                                                                                                                                                                                                             
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: <1>
  Actual: <0>

When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49  throw_
../packages/test_api/src/expect/async_matcher.dart.js 164:22                     fail
../packages/test_api/src/expect/async_matcher.dart.js 159:12                     _expect
../packages/test_api/src/expect/async_matcher.dart.js 86:12                      expect$
../packages/flutter_test/src/deprecated.dart.js 7250:12                          expect$
binding_test.dart.js 636:23                                                      <fn>

If this is not a bug, but intentional, just add a comment with an [intended] tag to indicate that this should always be skipped.

flutter doctor
[✓] Flutter (Channel master, 2.5.0-6.0.pre.28, on macOS 11.5.1 20G80 darwin-x64, locale en)
    • Flutter version 2.5.0-6.0.pre.28 at /Users/darrenaustin/dev/flutter
    • Upstream repository [email protected]:flutter/flutter.git
    • Framework revision d3bdbed498 (20 hours ago), 2021-08-06 17:45:02 -0700
    • Engine revision c0e59bc7b6
    • Dart version 2.14.0 (build 2.14.0-383.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/darrenaustin/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_SDK_ROOT = /Users/darrenaustin/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 59.0.4
    • Dart plugin version 212.4746.57

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.5.1 20G80 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 92.0.4515.131

• No issues found!

Activity

  1. added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    c: tech-debtTechnical debt, code quality, testing, etc.
    team: skip-testAn issue used to track tests that are skipped.
    on Aug 7, 2021
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    platform-webWeb applications specifically
    on Apr 27, 2022
  3. added
    P2Important issues not at the top of the work list
    on May 5, 2022
  4. removed their assignment
    on May 5, 2022
  5. harryterkelsen commented on Sep 30, 2026

    @harryterkelsen
    Contributor

    This test now passes on the web with CanvasKit, but it still fails with Skwasm (log):

    Expected: <1>
      Actual: <0>
    

    The '... Normal element mounting (' line never appears in the error details under Skwasm, so defaultStackFilter doesn't seem to recognize the framework Element mounting frames in Wasm stack traces.

    #193512 narrows the skip to skip: kIsWasm, so the test runs on CanvasKit. This issue stays open to track the Skwasm failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamteam: skip-testAn issue used to track tests that are skipped.triaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions