Skip to content

Canvas API is not tested #89

Closed
Closed

Description

@FlutterIssues

Issue by Hixie
Thursday Jul 16, 2015 at 22:45 GMT
Originally opened as https://github.com/flutter/engine/issues/63


From @Hixie on June 10, 2015 20:7

Copied from original issue: domokit/mojo#234

Activity

  1. added
    engineflutter/engine related. See also e: labels.
    a: tests"flutter test", flutter_test, or one of our tests
    c: new featureNothing broken; request for a new capability
    on Nov 9, 2015
  2. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by Hixie
    Thursday Jul 16, 2015 at 22:45 GMT


    From @mpcomplete on June 18, 2015 18:6

    Added a Gradient test in https://codereview.chromium.org/1185423003/ .

  3. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by Hixie
    Thursday Oct 08, 2015 at 17:22 GMT


    We don't even have a paint test harness anymore.

  4. modified the milestone: on Feb 3, 2016
  5. changed the title [-]Path, Gradients, etc, aren't tested by the unit tests[/-] [+]Canvas API is not tested[/+] on Sep 14, 2016
  6. Hixie commented on Sep 14, 2016

    @Hixie
    Contributor

    Specifically this issue is about the fact that dart:ui's graphics API has no testing. There's nothing that makes sure that, for instance, we don't accidentally change the default winding rule for path filling.

    This would be fixed by having reference tests or by having engine unit tests that can verify skia output.

  7. eseidelGoogle commented on Sep 14, 2016

    @eseidelGoogle
    Contributor

    Reference testing is tracked by #3227.

  8. Hixie commented on May 30, 2017

    @Hixie
    Contributor

    closing in favour of #3227 .

  9. github-actions commented on Aug 8, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: tests"flutter test", flutter_test, or one of our testsc: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions