Add PodFile.lock be added to the template gitignore #9299

Activity

1. eseidelGoogle

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Apr 10, 2017
2. eseidelGoogle

   added this to the 2: Make Early Adopters happy milestone on Apr 10, 2017
3. Hixie commented on Apr 11, 2017

   

   Hixie

   on Apr 11, 2017

   Contributor

   More actions

   we should add a test that verifies that the git status is clean after "flutter create && flutter run"

   👍React with 👍2Reacted by xster and Sarath Vadlamannati
4. jason-simmons commented on Apr 11, 2017

   

   jason-simmons

   on Apr 11, 2017

   Contributor

   More actions

   flutter_tools is also generating some source files that show up as untracked files in git:
   examples/flutter_gallery/android/app/src/main/java/
   examples/flutter_gallery/ios/Runner/PluginRegistry.h
   examples/flutter_gallery/ios/Runner/PluginRegistry.m

   @jakobr-google should these files be gitignored? or can they be moved outside the app's source tree and into a build output directory?
5. eseidelGoogle

   modified the milestones: 4: Make shippers happyThis milestone has been deleted, 2: Make Early Adopters happy on Apr 11, 2017
6. mit-mit commented on Apr 19, 2017

   

   mit-mit

   on Apr 19, 2017

   Member

   More actions

   No, according to https://guides.cocoapods.org/using/using-cocoapods.html PodFile.lock should not be ignored: "the Podfile and Podfile.lock should always be kept under version control."

   👍React with 👍54Reacted by Luke, 思迪, Paulo Rodrigues, Connor Elsea, Brandon Minnick, Michael Charland, Renan Matsunaga, Jonathan Madison, Jason Ashby, Andrew Henderson and 44 more

   ❤️React with ❤️6Reacted by Connor Elsea, 주성 B2C 사업부, Alexey Strakh, Muhammed Ballan, samir and Cícero Santos
7. mit-mit commented on Apr 19, 2017

   

   mit-mit

   on Apr 19, 2017

   Member

   More actions

   @jason-simmons we'll answer your question over in #9085, and let this bug track just the PodFile.lock question.
8. mit-mit commented on Apr 19, 2017

   

   mit-mit

   on Apr 19, 2017

   Member

   More actions

   Closing
9. mit-mit

   closed this as completedon Apr 19, 2017
10. eseidelGoogle commented on Apr 19, 2017

    

    eseidelGoogle

    on Apr 19, 2017

    ContributorAuthor

    More actions

    @mit-mit I'm not sure I believe that guide. The PodFile.lock has absolute paths in it:
    https://github.com/flutter/posse_gallery/pull/2/files#diff-cf4077ccb416bea5c1b3056a5a7c5299

    Are we doing something wrong? Clearly we don't want to check in absolute paths?
11. eseidelGoogle

    reopened this on Apr 19, 2017
12. mit-mit commented on Apr 24, 2017

    

    mit-mit

    on Apr 24, 2017

    Member

    More actions

    That guide is the official cocoapods guide...

    Here is another one:
    http://stackoverflow.com/questions/9446644/what-goes-into-your-gitignore-if-youre-using-cocoapods

    "The Podfile.lock must always be under source control."
    "source: I’m a member of the CocoaPods core team, like @alloy"

    However, the same stackoverflow posts also says that pods with a path dependency should be kept in source control.

    I suspect the issue here is our path dependency on engine? cc @jakobr-google
13. alloy commented on Apr 24, 2017

    

    alloy

    on Apr 24, 2017

    More actions

    Indeed, CocoaPods will write relative paths to the lockfile if relative paths are used in your Podfile, so if you check in the code with your project (or otherwise guarantee the code to always be in the same relative location) this should work.
14. mit-mit commented on Apr 24, 2017

    

    mit-mit

    on Apr 24, 2017

    Member

    More actions

    Thanks for the quick reply @alloy :-)

    👍React with 👍2Reacted by Eloy Durán and Sawan Kumar Bundelkhandi

    😄React with 😄1Reacted by Eloy Durán
15. 5 remaining items

    Load more
16. xtheandrew

    added a commit that references this issue on Mar 18, 2020

    Update after first iOS build

    ...

    787e40a
17. jmagman commented on Apr 23, 2020

    

    jmagman

    on Apr 23, 2020

    Member

    More actions

    The Podfile.lock no longer has absolute paths in it as of #42029. Reopening.
18. jmagman

    reopened this on Apr 23, 2020
19. jmagman

    changed the title [-]Should PodFile.lock be added to our template gitignore?[/-] [+]Add PodFile.lock be added to the template gitignore[/+] on Apr 23, 2020
20. jmagman

    added

    platform-iosiOS applications specificallyiOS applications specifically

    on Apr 23, 2020
21. kf6gpe

    added

    P2Important issues not at the top of the work listImportant issues not at the top of the work list

    on May 29, 2020
22. kf6gpe

    removed this from the GoalsThis milestone has been deleted milestone on Jun 2, 2020
23. Hixie

    removed this from the GoalsThis milestone has been deleted milestone on Jun 2, 2020
24. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
25. jmagman commented on Oct 20, 2020

    

    jmagman

    on Oct 20, 2020

    Last edited by jmagman

    Member

    More actions

    Not sure when this happened, but Podfile.lock is no longer excluded from the gitignore. I just created a new app, git inited a new project, ran flutter build ios and flutter build macos and now I see a ios/Podfile.lock and macos/Podfile.lock as an untracked (not ignored) file.

    Untracked files:
      (use "git add <file>..." to include in what will be committed)
    	ios/Podfile
    	ios/Podfile.lock
    	macos/Podfile
    	macos/Podfile.lock
    

    Closing.

    (I know this issue was asking if it should be included at all, and it should based on CocoaPod's own docs, and now it's actually versionable).
26. jmagman

    closed this as completedon Oct 20, 2020
27. tapizquent commented on Jan 9, 2021

    

    tapizquent

    on Jan 9, 2021

    More actions

    I have noticed that this files along with ios/Runner.xcodeproj/project.pbxproj get updated/changed when multiple people are working in the same project.

    If I understand right, should this not be included in .gitignore? How do we handle the changes that happen in those files?

    👀React with 👀1Reacted by Matthew Kooshad
28. jmagman commented on Jan 11, 2021

    

    jmagman

    on Jan 11, 2021

    Member

    More actions

    I have noticed that this files along with ios/Runner.xcodeproj/project.pbxproj get updated/changed when multiple people are working in the same project.

    ios/Runner.xcodeproj/project.pbxproj is periodically changed by Flutter to fix various behavior changes in Xcode. You should check in those changes.

    Podfile.lock should not changes between different user runs any more than pubspec.lock. Avoid running pod update in the ios directory (unless you are trying to update your dependencies). Also all your contributors should be on the same version of CocoaPods and Flutter.
29. github-actions commented on Aug 7, 2021

    

    github-actionsbot

    on Aug 7, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
30. github-actions

    locked as resolved and limited conversation to collaborators on Aug 7, 2021