[Proposal][Desktop] Let "ESC" key de-select currently selected item #94965

Activity

1. danagbemava-nc

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Dec 10, 2021
2. danagbemava-nc

   changed the title [-]Desktop: have "ESC" key de-select currently selected item[/-] [+][Proposal][Desktop] Let "ESC" key de-select currently selected item[/+] on Dec 10, 2021
3. danagbemava-nc

   added

   a: desktopRunning on desktopRunning on desktop

   a: text inputEntering text in a text field or keyboard related problemsEntering text in a text field or keyboard related problems

   passed first triage

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Dec 10, 2021
4. HansMuller

   added

   a: error messageError messages from the Flutter frameworkError messages from the Flutter framework

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   on Dec 13, 2021
5. HansMuller commented on Dec 13, 2021

   

   HansMuller

   on Dec 13, 2021

   Contributor

   More actions

   Interesting proposal. CC @gspencergoog
6. gspencergoog

   added

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Dec 16, 2021
7. justinmc commented on Feb 11, 2022

   

   justinmc

   on Feb 11, 2022

   Contributor

   More actions

   @Seirdy Could you provide a code sample to reproduce this?

   If the selection has caused the focus to change and we can receive the escape key, then I think this could be a straightforward fix by firing something like a DismissIntent.
8. Seirdy commented on Feb 11, 2022

   

   Seirdy

   on Feb 11, 2022 via email

   Last edited by Seirdy

   Author

   More actions

   On Fri, Feb 11, 2022 at 10:42:57AM -0800, Justin McCandless wrote: ***@***.*** Could you provide a code sample to reproduce this? I was simply referred to this bugtracker from the Fluffychat bugtracker; I'm not a Flutter dev. Maybe KrilleFear could share; I'll ping him in the Fluffychat Matrix room.

   If the selection has caused the focus to change and we can receive the escape key, then I think this could be a straightforward fix by firing something like a DismissIntent.

   I think that any sort of selection or focus, from tab-selection, text-selection, long-tap selection (IDK what the technical term is but that's what's in the screenshot), to being in a text box, should be cancelled with ESC. If I'm in a text box but I press ESC then tab, I shouldn't type a tab; I should change focus. If I'm using keyboard nav with tab-selection and arrow-key navigation, pressing ESC should cancel it. Otherwise, I have to use the mouse to quit keyboard navigation, which kind of defeats the point of keyboard navigation. Essentially this could be considered a meta-issue for grouping together all forms of deselection that ESC should handle.
9. markusaksli-nc commented on Feb 15, 2022

   

   markusaksli-nc

   on Feb 15, 2022

   Last edited by markusaksli-nc

   Contributor

   More actions

   So aside from #98163 and #84416 what else is missing this? It would be helpful to aggregate places where this doesn't work as expected.

   I'm slightly concerned about how far exactly this should go since not everything is consistent on desktop. Would it be fair to expect ESC to de-select selected text? Should it unfocus a focused text field if no text is selected? I'm not sure what the general case is for these but playing around with the browser and my IDE there are conflicting approaches. It's certainly doable by just going through a few checks in EditableTextState.

   Also am I missing something or does pressing tab in EditableText just always navigate instead of entering anything?
10. 2 remaining items

    Load more
11. markusaksli-nc

    removed their assignment

    on Mar 18, 2022
12. Seirdy commented on Jul 7, 2022

    

    Seirdy

    on Jul 7, 2022

    Author

    More actions

    This could also be considered an accessibility issue, as failing to de-select an item would violate all three levels of WCAG 2.2's Guideline 2.1 (Keyboard Accessible). One of Flutter's selling points is accessibility; this makes anything that disqualifies it from the WCAG's most lenient conformance level a big deal.

    👍React with 👍1Reacted by Jacob Willden
13. helinanever

    moved this to To do in Nevercodeon Jul 18, 2022
14. helinanever

    added this to Nevercodeon Jul 18, 2022
15. TahaTesser

    removed this from Nevercodeon Oct 3, 2022
16. flutter-triage-bot

    added

    multiteam-retriage-candidate

    team-desktop

    triaged-desktop

    on Jul 7, 2023
17. Hixie

    removed

    passed first triage

    on Jul 8, 2023
18. Hixie

    removed

    multiteam-retriage-candidate

    on Mar 6, 2024
19. cbracken

    added

    team-text-inputOwned by Text Input teamOwned by Text Input team

    and removed

    team-desktop

    on Jun 7, 2024
20. flutter-triage-bot commented on Jun 7, 2024

    

    flutter-triage-botbot

    on Jun 7, 2024

    More actions

    The triaged-desktop label is irrelevant if there is no team-desktop label or fyi-desktop label.
21. flutter-triage-bot

    removed

    triaged-desktop

    on Jun 7, 2024
22. justinmc

    added

    triaged-text-inputTriaged by Text Input teamTriaged by Text Input team

    on Jun 27, 2024