Skip to content

Run Windows desktop tests under Visual Studio 2022 #96138

Open
Open
Run Windows desktop tests under Visual Studio 2022#96138
Labels
P3Issues that are less important to the Flutter projecta: tests"flutter test", flutter_test, or one of our testsengineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyteam-windowsOwned by the Windows platform teamtriaged-windowsTriaged by the Windows platform team

Description

@cbracken
cbracken
opened on Jan 4, 2022

In #85922 (resolved by #93426) we added support for Visual Studio 2022, however our LUCI/devicelab tests still run Visual Studio 2019.

In order to prevent regressions, we should add support for Visual Studio 2022 to our LUCI and devicelab infra and migrate our tests to run under VS 2022. Ideally, we should also continue to run tests on VS 2019 to prevent any breakages, but this isn't something we do today on other platforms (e.g. with Xcode on macOS).

Activity

  1. cbracken
    added
    a: tests"flutter test", flutter_test, or one of our tests
    engineflutter/engine related. See also e: labels.
    platform-windowsBuilding on or for Windows specifically
    team-infraOwned by Infrastructure team
    P2Important issues not at the top of the work list
    on Jan 4, 2022

  2. godofredoc commented on Mar 17, 2022

    @godofredoc
    godofredoc
    on Mar 17, 2022
    Contributor

    This requires to update the vsstudio cipd configuration files.

  3. godofredoc
    added
    passed secondary triage
    on Mar 17, 2022

  4. cbracken commented on Jul 28, 2022

    @cbracken
    cbracken
    on Jul 28, 2022
    MemberAuthor

    @godofredoc do you know if we already have a VS 2022 install available for the bots via CIPD, or will we need to create a new package?

  5. godofredoc commented on Jul 28, 2022

    @godofredoc
    godofredoc
    on Jul 28, 2022
    Contributor

    We don't have a 2022 package, we'll need to create a new bundle. This is the docs for the process: go/flutter-infra-vs

  6. flutter-triage-bot
    added
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    and removed
    team-infraOwned by Infrastructure team
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023

  7. flutter-triage-bot commented on Jul 8, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Jul 8, 2023

    Issue is assigned to multiple teams (infra, engine). Please ensure the issue has only one team-* label at a time. Use fyi-* labels to have another team look at the issue without reassigning it.
    The triaged-engine label is irrelevant if there is no team-engine label or fyi-engine label.

  8. 1 remaining item

  9. Hixie
    added
    team-infraOwned by Infrastructure team
    triaged-infraTriaged by Infrastructure team
    on Jul 8, 2023
  10. flutter-triage-bot
    removed
    triaged-infraTriaged by Infrastructure team
    on Jul 10, 2023

  11. flutter-triage-bot commented on Jul 10, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Jul 10, 2023

    This issue is missing a priority label. Please set a priority label when adding the triaged-infra label.

  12. cbracken
    added
    triaged-infraTriaged by Infrastructure team
    on Jul 11, 2023

  13. cbracken commented on Jul 11, 2023

    @cbracken
    cbracken
    on Jul 11, 2023
    MemberAuthor

    Re-adding triaged label; the issue has an existing priority.

  14. loic-sharma commented on Oct 13, 2023

    @loic-sharma
    loic-sharma
    on Oct 13, 2023
    Member

    FYI, Visual Studio 2019 will only receive security fixes after April 9 2024 (no platform updates nor functionality fixes) and will stop receiving security fixes April 10 2029.

    Resources:

  15. matanlurey
    added
    team-windowsOwned by the Windows platform team
    P3Issues that are less important to the Flutter project
    and removed
    team-infraOwned by Infrastructure team
    P2Important issues not at the top of the work list
    triaged-infraTriaged by Infrastructure team
    on Feb 22, 2025
  16. loic-sharma
    added
    triaged-windowsTriaged by the Windows platform team
    on Mar 24, 2025

  17. Gustl22 commented on Apr 26, 2026

    @Gustl22
    Gustl22
    on Apr 26, 2026
    Contributor

    Should we update this ticket to support VS 2026 then?
    Related: #176399

  18. Gustl22 commented on Oct 1, 2026

    @Gustl22
    Gustl22
    on Oct 1, 2026
    Contributor

    @cbracken @loic-sharma. I really struggle to build the engine in VS26 for different reasons (#193413, #191560), although I had success. I cannot actively push this by a code contribution as the CIPD package is a private resource.
    This would be awesome to avoid regression and make contributor and developer experience on windows more successful. More:
    https://discord.com/channels/608014603317936148/1547949496326160395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: tests"flutter test", flutter_test, or one of our testsengineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyteam-windowsOwned by the Windows platform teamtriaged-windowsTriaged by the Windows platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions