Repository navigation
Conversation
The MSVC 14.52 STL declares std::modf as [[nodiscard]] (14.51 does not).
RoundToHalf in line_geometry.cc called std::modf only for its integral
part output parameter and discarded the return value, which breaks the
Windows engine build because warnings are treated as errors:
../../flutter/impeller/entity/geometry/line_geometry.cc(86,3): error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result]
86 | std::modf(x, &whole);
| ^~~~~~~~~~~~~~~~~~~~
Use std::trunc instead, which returns the integral part directly and
yields the same value as std::modf's integral part for all inputs,
including infinities and NaN.
Related to flutter#96138.
Contributor
Author
|
This PR is maybe test exempt as I did not change any logic. It could be tested by just running the pipeline in VS 2026, but it still needs the CIPD package for that. See #96138 |
8 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSVC 14.52 STL declares std::modf as
[[nodiscard]](14.51 does not). RoundToHalf in line_geometry.cc called std::modf only for its integral part output parameter and discarded the return value, which breaks the Windows engine build because warnings are treated as errors:Use std::trunc instead, which returns the integral part directly and yields the same value as std::modf's integral part for all inputs, including infinities and NaN.
Related to #96138.
For transparency: This PR was partially created with help of Claude.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.