Skip to content

Linux framework_tests_libraries flakes on bottom_navigation_bar_test #97162

Description

@keyonghan

(part of #97036)
These data is based Q4 2021 flakes that happened from 10/01/2021 to 01/13/2022

00:32 +578: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/bottom_navigation_bar_test.dart: BottomNavigationBar shifting backgroundColor with transition pump 3                                  
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following _Exception was thrown while running async test code:
Exception: Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold:
stdout: Given image with hash fd670f425cd626eb861b54a513120299 for test
material.bottom_navigation_bar.shifting_transition.2
Expectation for test: 643ca9c7b96d87509653e26737b651b6 (positive)
Expectation for test: 281c2726e383bd5fc274cec9336cb9b5 (positive)
Expectation for test: 4706a5ff2cff8ba60f67a5a85504a406 (positive)
Expectation for test: e72b7b2c872edc845832fc0de8eb2386 (positive)
Expectation for test: 8af64924411135da193cb2c3ca21fa62 (positive)
Expectation for test: d052b5016c053abd0598eb79eb931d45 (positive)
Expectation for test: fe86884b8cba0d8caf8682d07a9cec76 (positive)
Expectation for test: 19892a539285264eb18efd76cdfac1b4 (positive)
Expectation for test: 251f92738e2247084de3dd647d40b9b2 (positive)
Expectation for test: 37b3ec2e4b2219ef6bac52a4a879562c (positive)
Expectation for test: 430a6f0f05ae730debdc7a6a72f04e33 (positive)
Expectation for test: 58810f08b7ced49c72ea11dc5cdb9a7a (positive)
Expectation for test: 6cd2aaad3dc42f05d26f105704184d7b (positive)
Expectation for test: a4b5b31f3a02fb62a6984c67bf29ed96 (positive)
Expectation for test: 04068f7c55c80dabd48285e8f3fe9386 (positive)
Expectation for test: 12ed26d9747a57b07b1aca3ecd1d4185 (positive)
Expectation for test: 2d8e80674d3ec04f9c7dd35b900825e6 (positive)
Untriaged or negative image:
https://flutter-gold.skia.org/detail?test=material.bottom_navigation_bar.shifting_transition.2&digest=fd670f425cd626eb861b54a513120299


stderr: Test: material.bottom_navigation_bar.shifting_transition.2 FAIL

When the exception was thrown, this was the stack:
#0      SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:215:7)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════

00:32 +578 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/bottom_navigation_bar_test.dart: BottomNavigationBar shifting backgroundColor with transition pump 3 [E]                           
  Test failed. See exception logs above.
  The test description was: pump 3

Activity

  1. keyonghan commented on Jan 25, 2022

    @keyonghan
    ContributorAuthor

    /cc @Piinks Another one. seems gold related. One possible related issue: #94729

  2. Piinks commented on Jan 25, 2022

    @Piinks
    Contributor

    Also not a flake, please see the error message. :)

    This was from December. This is a signal that someone merged a PR without triaging an image change in pre-submit. I can see from the Flutter Gold triage log, that on the same day the images in question were updated: https://flutter-gold.skia.org/triagelog

    I don't think this is a flake, nor an active issue at this time. The test failed as expected to notify of an image change that was not handled in pre-submit.

  3. keyonghan commented on Jan 25, 2022

    @keyonghan
    ContributorAuthor

    Closing as the issue has been fixed.

  4. github-actions commented on Feb 8, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions