You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[cocoon] Refactor LuciBuildService to generally work #97687
There's several methods like rescheduleProdBuildrescheduleTryBuildscheduleTrybuildscheduleProdBuild that we could have share logic instead of duplicating. This would make it easier to read and change buildbucket related logic.
Ideally, we want a _scheduleBuild that these all internal refer to, with minor additions in their respective calls.
Additionally, we want to migrate off the terms try and prod to presubmit and postsubmit to make it clearer.
@CaseyHillers only one of the four functions you mentioned are present in the file is present (scheduleTrybuild) and the remaining functions don't seem to share a significant amount of logic. is this issue still open?
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
bharat94 commentedon Feb 21, 2022
Is this still open? Should we close this issue?
CaseyHillers commentedon Mar 4, 2022
This is still open. There's a lot of duplicate code in that class that's causing issues like #99523
SoroushBeigi commentedon Mar 12, 2024
@CaseyHillers only one of the four functions you mentioned are present in the file is present (scheduleTrybuild) and the remaining functions don't seem to share a significant amount of logic. is this issue still open?
github-actions commentedon Mar 8, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.