Skip to content

[cocoon] Refactor LuciBuildService to generally work #97687

Closed as not planned
Closed as not planned

Description

@CaseyHillers

There's several methods like rescheduleProdBuild rescheduleTryBuild scheduleTrybuild scheduleProdBuild that we could have share logic instead of duplicating. This would make it easier to read and change buildbucket related logic.

Ideally, we want a _scheduleBuild that these all internal refer to, with minor additions in their respective calls.

Additionally, we want to migrate off the terms try and prod to presubmit and postsubmit to make it clearer.

Activity

  1. self-assigned this
    on Feb 3, 2022
  2. bharat94 commented on Feb 21, 2022

    @bharat94

    Is this still open? Should we close this issue?

  3. CaseyHillers commented on Mar 4, 2022

    @CaseyHillers
    ContributorAuthor

    Is this still open? Should we close this issue?

    This is still open. There's a lot of duplicate code in that class that's causing issues like #99523

  4. removed their assignment
    on Jul 14, 2022
  5. added
    P3Issues that are less important to the Flutter project
    triaged-infraTriaged by Infrastructure team
    on Aug 23, 2023
  6. SoroushBeigi commented on Mar 12, 2024

    @SoroushBeigi

    @CaseyHillers only one of the four functions you mentioned are present in the file is present (scheduleTrybuild) and the remaining functions don't seem to share a significant amount of logic. is this issue still open?

  7. github-actions commented on Mar 8, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions