During "flutter build ipa" add validation to check if app is ready for release

For all of these, either point to the docs, or inline instructions for how to fix it

Example warnings

App icon is still set to default, point to https://docs.flutter.dev/deployment/ios#add-an-app-icon or in-line how to change
App display name is set to package name (the default, probably not right)

Informational output

Build number https://docs.flutter.dev/deployment/ios#updating-the-apps-version-number
Minimum iOS version
App display name
Other settings from https://docs.flutter.dev/deployment/ios#review-xcode-project-settings

@hellohuanlin

@hellohuanlin you can test flutter_gallery

Around here the xcodeBuildResult property should be populated.

flutter/packages/flutter_tools/lib/src/commands/build_ios.dart

Line 136 in e99fc8e

final FlutterCommandResult xcarchiveResult = await super.runCommand();

From that you can get the build settings from xcodeBuildResult.xcodeBuildExecution.buildSettings.
IPHONEOS_DEPLOYMENT_TARGET will get you the minimum iOS version.

You can add property to BuildableIOSApp to the built app Info.plist path, then parse the Info.plist to get the "name" CFBundleExecutable, the version CFBundleShortVersionString, and you could alternatively get MinimumOSVersion instead of from the build settings.
Similar to:

flutter/packages/flutter_tools/lib/src/ios/application_package.dart

Lines 54 to 62 in dcde816

    
           final String plistPath = globals.fs.path.join(uncompressedBundle.path, 'Info.plist'); 
        
           if (!globals.fs.file(plistPath).existsSync()) { 
        
             globals.printError('Invalid prebuilt iOS app. Does not contain Info.plist.'); 
        
             return null; 
        
           } 
        
           final String? id = globals.plistParser.getStringValueFromFile( 
        
             plistPath, 
        
             PlistParser.kCFBundleIdentifierKey, 
        
           );

The first approach (build_ios.dart) works.

For the second approach(application_package.dart), I got the following error before hitting the breakpoint:

Encountered error while creating the IPA:
error: exportArchive: Failed to register bundle identifier
error: exportArchive: No profiles for 'io.flutter.examples.gallery' were found

Does this mean that I need to setup Apple dev account (register ID & download profile)?

Encountered error while creating the IPA:

Exactly, it means you don't have the right certs installed. For this bug you can ignore that, I think it makes sense to validate when the app archives successfully, even if it fails to create the IPA.

In case we forgot: another idea is to check entitlements. This may require plugins to publish what permissions they need.

In case we forgot: another idea is to check entitlements. This may require plugins to publish what permissions they need.

x-ref #39444

Idea: check for com.example placeholder identifier, in case developers forget to update

we may also want to validate the image size of app icons. Xcode gives warning about the wrong size, but developers may directly replace images without using Xcode (me, for example).

@jmagman

@jmagman another idea is to validate if splash screen (Default.png) is still using template file. Our template seems to be an empty image rather than Flutter icon, so it may be easier for devs to overlook.

@hellohuanlin

Thanks for all the work on these PRs, @hellohuanlin! I'm going to close this meta issue, we can open new individual issues as needed.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

During "flutter build ipa" add validation to check if app is ready for release #97730

Example warnings

Informational output

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	final String plistPath = globals.fs.path.join(uncompressedBundle.path, 'Info.plist');
	if (!globals.fs.file(plistPath).existsSync()) {
	globals.printError('Invalid prebuilt iOS app. Does not contain Info.plist.');
	return null;
	}
	final String? id = globals.plistParser.getStringValueFromFile(
	plistPath,
	PlistParser.kCFBundleIdentifierKey,
	);

During "flutter build ipa" add validation to check if app is ready for release #97730

Description

Example warnings

Informational output

Activity

jmagman commented on Oct 6, 2022

hellohuanlin commented on Oct 10, 2022

jmagman commented on Oct 11, 2022

hellohuanlin commented on Oct 17, 2022

jmagman commented on Oct 17, 2022

hellohuanlin commented on Oct 27, 2022

hellohuanlin commented on Nov 7, 2022

hellohuanlin commented on Nov 18, 2022

jmagman commented on Dec 2, 2022

github-actions commented on Mar 5, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions