Skip to content

The ci_yaml roller should support target level dimension override #98274

Closed

Description

@keyonghan

Context: #98210 overrides OS and Xcode version on target level, only the properties Xcode version was rolled to corresponding target config: https://flutter-review.googlesource.com/c/infra/+/26740/2/config/generated/flutter/luci/cr-buildbucket.cfg

The dimension is currently referencing only on platform level: https://flutter.googlesource.com/infra/+/refs/heads/main/config/lib/ci_yaml/ci_yaml.star#315

The roller should support dimension override as well for cases where we need to override for specific targets.

Activity

  1. godofredoc commented on Mar 24, 2022

    @godofredoc
    Contributor

    This has been implemented.

  2. github-actions commented on Apr 7, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions