Skip to content

Override OS and Xcode version for plugin_lint_mac - #98210

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:lint-properties
Feb 10, 2022
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:lint-properties

Conversation

@jmagman

@jmagman jmagman commented Feb 10, 2022

Copy link
Copy Markdown
Member

Work around #97303 by trying the newer version of Xcode and macOS.

@jmagman jmagman added the team-infra Owned by Infrastructure team label Feb 10, 2022
@jmagman jmagman self-assigned this Feb 10, 2022
Comment thread .ci.yaml
tags: >
["devicelab","hostonly"]
task_name: plugin_lint_mac
os: Mac-12 # Override OS and Xcode for https://github.com/flutter/flutter/issues/97303

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the todo that this would eventually become the default for all the Mac tests?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works is being done in #98144.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, that work is being done with #98144.

@jmagman

jmagman commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

Same issue seen in #98144 it's not using the os override and it's installing the new version of Xcode on an old version of macOS, which fails. https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11020?

@keyonghan

Copy link
Copy Markdown
Contributor

flutter/cocoon#1597 to pass dimensions in pre-submit tests.

@jmagman

jmagman commented Feb 10, 2022 •

Copy link
Copy Markdown
Member Author

Here's a led run: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/af6dcdfeb5944e5d9b977d7d8d9425c61b920f931049cdc368da8046e5560806/+/build.proto?server=chromium-swarm.appspot.com

I expect this to fail until #98165 is fixed, we just need it to actually run the test without an Xcode infra failure. Then I can rebase #98171 onto this to see it actually pass.

@jmagman

jmagman commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

Test failed as expected as in #98165, but not on any Xcode on infra issues.
Ready to merge with LGTM to rebase that fix and reopen the tree.

@jmagman

jmagman commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

Merging on red.

@jmagman
jmagman merged commit c1c96ef into flutter:master Feb 10, 2022
@jmagman
jmagman deleted the lint-properties branch February 10, 2022 21:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2022
@jmagman jmagman mentioned this pull request Feb 10, 2022
6 of 8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@jmagman jmagman mentioned this pull request Feb 11, 2022
8 tasks done
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Feb 18, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants