Skip to content

Refactor ToggleButtons  #99085

Closed
#101760
#99493
Closed
Refactor ToggleButtons #99085
#101760
#99493
Assignees
TahaTesser
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Description

@Piinks
Piinks
opened on Feb 24, 2022

ToggleButtons use RawMaterialButton which is scheduled to be deprecated and removed (eventually).
We need to refactor them to use the new button universe, either TextButton, OutlinedButton or ElevatedButton.

cc @TahaTesser and @HansMuller

Completing this will likely resolve #97302 as well.

Activity

  1. Piinks
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Feb 24, 2022

  2. Piinks commented on Feb 24, 2022

    @Piinks
    Piinks
    on Feb 24, 2022
    ContributorAuthor

    Assigning to @TahaTesser per our chat today

  3. Piinks
    assigned
    TahaTesser
    on Feb 24, 2022
  4. fluttergithubbot
    closed this as completedin #99493on Mar 31, 2022
  5. TahaTesser
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Apr 1, 2022

  6. Piinks commented on Apr 7, 2022

    @Piinks
    Piinks
    on Apr 7, 2022
    ContributorAuthor

    Re-opening as the change is being reverted

  7. Piinks
    reopened this on Apr 7, 2022
  8. Piinks
    removed
    r: fixedIssue is closed as already fixed in a newer version
    on Apr 7, 2022
  9. fluttergithubbot
    closed this as completedin #101760on Apr 27, 2022

  10. github-actions commented on May 11, 2022

    @github-actions
    github-actionsbot
    on May 11, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on May 11, 2022
  12. helinanever
    moved this to Done (PR merged) in Nevercodeon Jul 18, 2022
  13. helinanever
    added this to Nevercodeon Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

  • Nevercode
    Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions