Repository navigation
[go_router] Support multiple navigation stacks #99126
Description
Activity
Its great that go_router got merged into flutter. Had a feeling this was the
go-to router due to its dead simple use.But for it to be truly useful we need to get it to work with bottomNavigation. Maybe it already does, but if not this has to be priority 1 if this package is still being worked on. Please don't P4 this :) :)
Reacted by fullflash, mark8044, OppositeDragon, David, Giuseppe Cianci, max-insight, Vadim Ledyaev, Iskander Shamsudinov, Ricardo Oliveira, Andrei Nebogatikov and 32 moreHey, thank you for this great package and congratulations for making it into flutter today ! 🎉
I would like to know if this still a top priority issue for the go_router package ?
And most importantly, does the team have a target release date, or at least a time window for this ?I am starting a new project and I would love to use go_router in my project, today more than ever as it officially became part of Flutter. Unfortunately this feature is what is keeping me from using go_router. This info could help choose if I have to use another package ( 😞 ) or if I should wait a little (working on other parts of the app) for this feature to come out.
Thanks and congrats again
Reacted by mark8044, wei, Henry (Haim) Benhaim, David, Giuseppe Cianci, max-insight, Vadim Ledyaev, Iskander Shamsudinov, Ricardo Oliveira, Andrei Nebogatikov and 15 moreWe use thumbs up to prioritize the feature requests, but currently my top-most priority is to clean up the code and apply flutter lint. In the meantime, feel free to submit a pr if you may have idea to add this feature.
Reacted by mark8044, Islam Akhrarov, ofekd, kioxia, David, Giuseppe Cianci, max-insight, Vadim Ledyaev, Ricardo Oliveira, Andrei Nebogatikov and 13 more@chunhtai We need something like this https://youtu.be/9oH42_Axr3Q
Reacted by mark8044, wei, ofekd, Philipp H. Gerber, Jiten Basnet, David, max-insight, Vadim Ledyaev, Iskander Shamsudinov, Andrei Nebogatikov and 17 moreyes this is must feature for any router/navigation package.
Reacted by mark8044, wei, Islam Akhrarov, Jiten Basnet, Bryan Oltman, David, max-insight, Vadim Ledyaev, Iskander Shamsudinov, Ricardo Oliveira and 17 morePlease everyone give a thumbs up to the above posts (especially the first post)
It sounds like that's how they will gauge if they will do any work on this issue. Im giddy to try using go_router and just waiting for this one issue to progress ...
Reacted by Islam Akhrarov, Henry (Haim) Benhaim, David, max-insight, Vadim Ledyaev, Iskander Shamsudinov, Ricardo Oliveira, Andrei Nebogatikov, horgag, Sergey Drozhzhin and 17 moreYes, please. 👍
- Reacted by Iain Smith, Tobias Marschall, Harshil Patel, mono — Masayuki Ono, Emilio Rodríguez, Shah Jash, Hiroki Kajiwara, Luke, teneon, dastein1 and 8 moreReacted by Shah Jash, dastein1 and Brighton Chabula
I agree with @rahulrmishra . @chunhtai Can we have any update if this feature is being implemented or any timeline by when will it be implemented. This is a very common use case and needs urgent attention
Reacted by Rahul Mishra, Shah Jash, Hiroki Kajiwara, mono — Masayuki Ono, Tobias Marschall, Luke, Stephen C., Brighton Chabula, Harry Sild, David and 2 moreReacted by Shah Jash, Tobias Marschall, Brighton Chabula and SamKlim40 remaining items
I actually use go_router_prototype for a web app that's going to production soon 😅, it was the only solution for nested navigation. It has some limitations since it's just a prototype, but i did some workarounds to work with it. I can say it's pretty awesome and doing its job just fine 👍🏻
@johnpryan Waiting to use the official version!
Just checked the PR you mentioned, what will happen to go_router_prototype now? should I migrate to GoRouter and use ShellRoute?
@michaelsoliman1 yes, I would consider go_router_prototype deprecated. Let us know if you have any issues migrating.
Reacted by Michael SolimanDoes it mean you got rid of these confusing StackedRoute and NestedStackRoute and finally left a ShellRoute only?
@subzero911 yes, there is only ShellRoute and GoRoute.
Reacted by Sergio Molchanovsky and Andrea BizzottoI like this final variant.
Reacted by John Ryan@johnpryan any idea when this will be merged into the main package?
People, respectfully, and this goes for open source in general, asking for an ETA tends to only delay the ETA, because it's just another notification to deal with in somebody's inbox. If you look at the branch John Ryan linked to it seems there's active review and discussion going on, so it's coming!
Reacted by mono — Masayuki Ono, Agon Noga, Chris Yi and Adrien BonninReacted by Social JawnReacted by Josh HuckabeePeople, respectfully, and this goes for open source in general, asking for an ETA tends to only delay the ETA, because it's just another notification to deal with in somebody's inbox. If you look at the branch John Ryan linked to it seems there's active review and discussion going on, so it's coming!
The reason for me asking is because that package doesn't contain the other changes that are in the 5.0 branch for go router some of which I really do need. Also having a timetable helps other developers to know when they can complete a task or release an app.
WOAH, it looks like we've made it? Is there an example on how to do a Cupertino bottom navigation bar using this shiny new v5 release?
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Oct 1, 2022
copied from csells/go_router#82
e.g. https://medium.com/coding-with-flutter/flutter-case-study-multiple-navigators-with-bottomnavigationbar-90eb6caa6dbf