Skip to content

New buttons should use InkSparkle for splashFactory when useMaterial3 is true #99884

Description

@clocksmith

Currently, the new buttons provide their own splashFactory and do not inherit the ThemeData.splashFactory.

One solution is for the buttons need to manually adjust the splashFactory the same way ThemeData does.

Another solution would be to make sure that the new Buttons properly inherit splashFactory from ThemeData.

Activity

  1. changed the title [-][Material] New buttons should use InkSparkle when useMaterial3 is true[/-] [+][Material] New buttons should use InkSparkle for splashFactory when useMaterial3 is true[/+] on Mar 10, 2022
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: new featureNothing broken; request for a new capability
    on Mar 10, 2022
  3. github-actions commented on May 10, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on May 10, 2022
  5. moved this to Todo in Material 3on May 23, 2022
  6. moved this from Todo to Done in Material 3on May 23, 2022
  7. changed the title [-][Material] New buttons should use InkSparkle for splashFactory when useMaterial3 is true[/-] [+]New buttons should use InkSparkle for splashFactory when useMaterial3 is true[/+] on May 23, 2022
  8. changed the title [-]New buttons should use InkSparkle for splashFactory when useMaterial3 is true[/-] [+]New buttons should use `InkSparkle` for `splashFactory` when `useMaterial3` is true[/+] on May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

c: new featureNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions