Repository navigation
Put stretch indicator behind useMaterial3 flag - #100234
Merged
Merged
Conversation
Piinks
added
framework
flutter-dashboard
Bot
added
the
f: scrolling
darrenaustin
approved these changes
Mar 16, 2022
darrenaustin
left a comment
darrenaustin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Awesome Kate. I as just about to ask you what I needed to do for this 😄.
Can you also add a comment to the docs for useMaterial3 to indicate that it turns this feature on for Android platforms? Thx.
| final AndroidOverscrollIndicator indicator = _androidOverscrollIndicator | ||
| late final AndroidOverscrollIndicator indicator; | ||
| if (Theme.of(context).useMaterial3) { | ||
| indicator = AndroidOverscrollIndicator.stretch; |
Contributor
There was a problem hiding this comment.
This only applies to the Android platform, correct? We don't perform the overscroll on anything else?
|
Gold has detected about 6 new digest(s) on patchset 2. |
|
Gold has detected about 1 new digest(s) on patchset 3. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 21, 2022
63 of 70 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
guidezpl
changed the title
useMaterial3 flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the implementation of the stretching overscroll indicator to be enabled by the
useMaterial3flag.It deprecates the previous
androidOverscrollIndicatorproperty, as part of unifying M3 features and making its way to the new default.Related to:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.