Skip to content

Revert "[framework] don't hit test for system nav bar or system chrome on desktop" - #100263

Merged
fluttergithubbot merged 1 commit into
masterfrom
revert-97883-benchy_mc_benchface_2
Mar 17, 2022
Merged

fluttergithubbot merged 1 commit into
masterfrom
revert-97883-benchy_mc_benchface_2

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Reverts #97883

We're missing integration tests for this functionality

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 17, 2022

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 984d8a8 into master Mar 17, 2022
@fluttergithubbot
fluttergithubbot deleted the revert-97883-benchy_mc_benchface_2 branch March 17, 2022 23:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants