Skip to content

Add --use-application-binary to "flutter install" - #101324

Merged
jmagman merged 2 commits into
flutter:masterfrom
jmagman:install-binary
Apr 6, 2022
Merged

Add --use-application-binary to "flutter install"#101324
jmagman merged 2 commits into
flutter:masterfrom
jmagman:install-binary

Conversation

@jmagman

@jmagman jmagman commented Apr 5, 2022

Copy link
Copy Markdown
Member

Allow installation of pre-built binaries, including with flavors.

Tested by building an ad-hoc IPA of the flavors example:

$ flutter build ipa --flavor free --export-method ad-hoc
Archiving dev.flutter.flavors.free...
Warning: Missing build name (CFBundleShortVersionString).
Warning: Missing build number (CFBundleVersion).
Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633
Running Xcode build...
 └─Compiling, linking and signing...                         4.0s
Xcode archive done.                                         17.4s
Built /Users/m/Projects/flutter/dev/integration_tests/flavors/build/ios/archive/Free App.xcarchive.

💪 Building with sound null safety 💪

Building ad-hoc IPA...                                              6.3s
Built IPA to /Users/m/Projects/flutter/dev/integration_tests/flavors/build/ios/ipa.

And

$ flutter install --use-application-binary build/ios/ipa/Free\ App.ipa
Installing dev.flutter.flavors.free to iPad...
$ flutter install --use-application-binary build/ios/ipa/Free\ App.ipa --uninstall-only
Uninstalling dev.flutter.flavors.free from iPad...

#99607 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 5, 2022
@jmagman jmagman self-assigned this Apr 5, 2022
christopherfujino
christopherfujino reviewed Apr 5, 2022
View reviewed changes
Comment thread packages/flutter_tools/lib/src/commands/install.dart Outdated

@christopherfujino christopherfujino Apr 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a helper function shared by the run command in flutter_command.dart? https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/runner/flutter_command.dart#L203

christopherfujino
christopherfujino approved these changes Apr 5, 2022
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit about using a helper for the flag

christopherfujino
christopherfujino approved these changes Apr 5, 2022
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, thanks!

Jasguerrero
Jasguerrero approved these changes Apr 6, 2022
View reviewed changes

@Jasguerrero Jasguerrero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented Apr 6, 2022

Copy link
Copy Markdown
Member Author

Google testing borked, merging.

@jmagman
jmagman merged commit d745eec into flutter:master Apr 6, 2022
@jmagman
jmagman deleted the install-binary branch April 6, 2022 20:17
@jmagman jmagman mentioned this pull request Apr 6, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2022
@engine-flutter-autoroll
d745eec Add --use-application-binary to "flutter install" (flutter/fl…
31bcc7c 
…utter#101324)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 6, 2022
@engine-flutter-autoroll
d745eec Add --use-application-binary to "flutter install" (flutter/fl…
cf4d322 
…utter#101324)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 6, 2022
@engine-flutter-autoroll
d745eec Add --use-application-binary to "flutter install" (flutter/fl…
2a57493 
…utter#101324)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 7, 2022
@engine-flutter-autoroll
d745eec Add --use-application-binary to "flutter install" (flutter/fl…
e43858d 
…utter#101324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@christopherfujino christopherfujino christopherfujino approved these changes
@Jasguerrero Jasguerrero Jasguerrero approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @Jasguerrero