Skip to content

[Cherrypick] Partial revert of super params in tools (#101436) - #101451

Merged
CaseyHillers merged 1 commit into
flutter:masterfrom
CaseyHillers:flutter-2.13-candidate.0
Apr 7, 2022
Merged

CaseyHillers merged 1 commit into
flutter:masterfrom
CaseyHillers:flutter-2.13-candidate.0

Conversation

@CaseyHillers

Copy link
Copy Markdown
Contributor

b/228329786

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2022
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers
CaseyHillers merged commit 548e885 into flutter:master Apr 7, 2022
@CaseyHillers
CaseyHillers deleted the flutter-2.13-candidate.0 branch April 7, 2022 01:20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 7, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 7, 2022
@CaseyHillers
CaseyHillers restored the flutter-2.13-candidate.0 branch April 7, 2022 18:17
@CaseyHillers
CaseyHillers deleted the flutter-2.13-candidate.0 branch April 7, 2022 19:24
MohammedTarigg pushed a commit to MohammedTarigg/flutter that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants