Repository navigation
[framework] fix slider regression due to touch slop changes - #103569
Merged
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
jonahwilliams
marked this pull request as ready for review
May 12, 2022 03:52
Contributor
Author
|
@xu-baolin I'll trade you 😄 |
xu-baolin
reviewed
May 12, 2022
| required TextDirection textDirection, | ||
| required bool hasFocus, | ||
| required bool hovering, | ||
| required DeviceGestureSettings gestureSettings, |
Member
There was a problem hiding this comment.
Should not this.gestureSettings?
Contributor
Author
There was a problem hiding this comment.
Since the only thing I do with gestureSettings is pass it to the gesture detectors below, we don't necessarily need a field to store the settings on this render object. The gesture detectors themselves are late and so aren't re-created outside of the constructor
xu-baolin
approved these changes
May 12, 2022
Contributor
Author
|
yes, an audit is in order. We might be able to speed things up by adding an assert if a gesture is received and gesture settings hasn't been set. I could also look into a breaking change process to make it required to prevent this from happening again. |
Member
|
👍 Glad to review! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 13, 2022
This comment was marked as spam.
This comment was marked as spam.
|
@jonahwilliams When will that fix make its way to a stable release? |
jonahwilliams
pushed a commit
to jonahwilliams/flutter
that referenced
this pull request
Jun 1, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Jun 1, 2022
…egressions (#105141) * [framework] fix slider regression due to touch slop changes (#103569) * fix `SliverReorderableList` not work on Android platform bug (#103406) Co-authored-by: xubaolin <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103566
Due to changes in #97971