Repository navigation
fix a Scaffold extendBodyBehindAppBar update bug - #104958
Merged
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
This was referenced May 30, 2022
Member
Author
|
Hi, @LongCatIsLooong, could you review this again? thx. |
LongCatIsLooong
approved these changes
Jun 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 16, 2022
xu-baolin
added a commit
that referenced
this pull request
Jun 22, 2022
This reverts commit ea28f28.
This was referenced Jun 22, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103741
Blocked by #104954
Blocked by #104998
Insert or remove a widget middle of the tree will cause all of the sub-tree to be detached and cause the body sub-tree to lose its state.
Two solutions,
1, Use a Global key
2, Keep the tree structure during configurations change
But I think the Global key is expensive.