Skip to content

Add transitionOnUserGestures to true on SnackBar for back swipe - #106638

Merged
Piinks merged 5 commits into
flutter:masterfrom
letsar:ios-snackbar-animation
Jul 19, 2022
Merged

Add transitionOnUserGestures to true on SnackBar for back swipe#106638
Piinks merged 5 commits into
flutter:masterfrom
letsar:ios-snackbar-animation

Conversation

@letsar

@letsar letsar commented Jun 26, 2022

Copy link
Copy Markdown
Contributor

Fixes #100782

Before :

snackbar_hero_ko.mp4

With this PR :

snackbar_hero_ok.mp4

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jun 26, 2022
@HansMuller
HansMuller requested a review from Piinks July 1, 2022 21:44
Piinks
Piinks reviewed Jul 7, 2022
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this! Can you add some documentation to SnackBar about this?

Comment thread packages/flutter/test/material/snack_bar_test.dart Outdated
@letsar

letsar commented Jul 9, 2022

Copy link
Copy Markdown
Contributor Author

I've added some documentation but I was not sure how to explain this behavior shortly. Let me know how to improve the documentation if it's not ok.

Piinks
Piinks approved these changes Jul 12, 2022
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2022
@auto-submit

auto-submit Bot commented Jul 12, 2022

Copy link
Copy Markdown
Contributor
  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submit Bot commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Validations Fail.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2022
@Piinks

Piinks commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Oh! We need a secondary review, I will find another reviewer.

justinmc
justinmc approved these changes Jul 12, 2022
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread packages/flutter/lib/src/material/snack_bar.dart Outdated
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2022
@letsar

letsar commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

@Piinks something is wrong with Google testing check? It's in pending state since a few days.

@Piinks

Piinks commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Yeah it looks like it got stuck, I checked and it passed. Merging manually.

@Piinks
Piinks merged commit be0c370 into flutter:master Jul 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
53950e5 
…pe (flutter/flutter#106638)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
2295c5e 
…pe (flutter/flutter#106638)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
c625817 
…pe (flutter/flutter#106638)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
36fc2d2 
…pe (flutter/flutter#106638)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
cb45827 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
0df88a8 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
e2d9eb1 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
8004fb6 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
3656890 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
58d5daf 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
13f28e7 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
6747d5e 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
44d0100 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
6b221cb 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
34d0b2c 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
8216eb1 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
e1c9978 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
9ee8730 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
cca43be 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
911ae7b 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
57fe82c 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
594dc76 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
f194213 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
4a0bf89 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
a5e8af1 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
6c861ed 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
4474292 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
87ac300 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
623e9eb 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
cbe3b73 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
6b15b7c 
…pe (flutter/flutter#106638)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
be0c370 Add transitionOnUserGestures to true on SnackBar for back swi…
6b711d8 
…pe (flutter/flutter#106638)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@letsar @camsim99
Add transitionOnUserGestures to true on SnackBar for back swipe (flut…
d0a819d 
…ter#106638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes
@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[IOS]No Hero animation with SnackBar on drag to pop gesture

3 participants

@letsar @Piinks @justinmc