Skip to content

Fix Scaffold setState during locked framework due to open drawer - #107173

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:drawer-orientation-fix
Jul 18, 2022
Merged

Fix Scaffold setState during locked framework due to open drawer#107173
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:drawer-orientation-fix

Conversation

@markusaksli-nc

@markusaksli-nc markusaksli-nc commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

When the drawer is open and gets disposed during locked framework it still removes its controller history entry in dispose, leading to a setState response in Scaffold to close the drawer. This led to an exception and a broken BackButton in the AppBar in certain situations.

This PR adds a check before the drawer and endDrawer opened callback setState to ensure that the drawer state still exists to avoid the issue. I considered adding it to a post-frame callback but it runs into the issue of the scaffold being disposed along with the drawer and then triggering setState for a disposed state.

Fixes #34978

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jul 6, 2022
@markusaksli-nc
markusaksli-nc force-pushed the drawer-orientation-fix branch from 013c27a to 7fc4719 Compare July 6, 2022 17:24
goderbauer
goderbauer reviewed Jul 8, 2022
View reviewed changes
Comment thread packages/flutter/lib/src/material/scaffold.dart Outdated
Comment thread packages/flutter/lib/src/material/scaffold.dart Outdated
Comment thread packages/flutter/test/material/drawer_test.dart Outdated
Comment thread packages/flutter/test/material/drawer_test.dart Outdated
Comment thread packages/flutter/test/material/drawer_test.dart Outdated
goderbauer
goderbauer reviewed Jul 8, 2022
View reviewed changes
Comment thread packages/flutter/test/material/drawer_test.dart Outdated
@markusaksli-nc
markusaksli-nc force-pushed the drawer-orientation-fix branch from 7fc4719 to 5cf29c5 Compare July 11, 2022 17:18
goderbauer
goderbauer approved these changes Jul 15, 2022
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusaksli-nc
markusaksli-nc force-pushed the drawer-orientation-fix branch from 5cf29c5 to 2708571 Compare July 18, 2022 09:39
@markusaksli-nc markusaksli-nc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2022
@auto-submit
auto-submit Bot merged commit da3b2a2 into flutter:master Jul 18, 2022
@markusaksli-nc
markusaksli-nc deleted the drawer-orientation-fix branch July 18, 2022 11:52
@markusaksli-nc markusaksli-nc mentioned this pull request Jul 18, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
f6d2029 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
9784db7 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
7f939c4 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
2c75ba4 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
ef3a6a3 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
70a9c69 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
5e28214 
… drawer (flutter/flutter#107173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
5b8a3bc 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
98eb002 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
e6a9a81 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
663796c 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
729da89 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
a40f877 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
ed75e09 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
34aed33 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
b848957 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
d56abe6 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
bf9a632 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
cdded47 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
fa017a4 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
b3a10a4 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
37e94f4 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
b52a68e 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
c2eb90f 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
d93cce8 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
0d1e3a2 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
009a625 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
bbe8e82 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
d53a1e4 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
ff153b8 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
640f9b2 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
4dbe604 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
22d6de7 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
e46d00a 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
0477cc5 
… drawer (flutter/flutter#107173)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
da3b2a2 Fix Scaffold setState during locked framework due to open…
4b5387a 
… drawer (flutter/flutter#107173)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@markusaksli-nc @camsim99
Fix Scaffold setState during locked framework due to open drawer (f…
e814b35 
…lutter#107173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When drawer is open, going to landscape orientation causes the the drawer to close and back button appears instead

2 participants

@markusaksli-nc @goderbauer