Repository navigation
Complete features of ScrollableList2 - #1074
Merged
Merged
Conversation
abarth
force-pushed
the
scrollable_list_features
branch
2 times, most recently
from
January 5, 2016 04:27
4a14757 to
4c6ef17
Compare
Contributor
Author
abarth
force-pushed
the
scrollable_list_features
branch
from
January 5, 2016 05:09
4c6ef17 to
c0d27d8
Compare
Contributor
Author
|
I added a second commit that updates all the callers to ScrollableList2. I kept them in separate commits so you can review them separately if you prefer. |
abarth
force-pushed
the
scrollable_list_features
branch
3 times, most recently
from
January 5, 2016 06:50
4a3f987 to
2c38ac1
Compare
Contributor
|
cc @HansMuller LGTM. |
This patch implements the remaining missing features of ScrollableList2. It should now be nearly a drop-in replacement for ScrollableList. The next patch will switch callers over to the new machinery.
This patch also changed ScrollableList2 to use an Iterable instead of an List for its children. This change lets clients map their underlying data lazily. If the clients actually have a concrete list, we skip the extra copy and grab the child list directly.
abarth
force-pushed
the
scrollable_list_features
branch
from
January 6, 2016 00:21
2c38ac1 to
b1f9138
Compare
abarth
added a commit
that referenced
this pull request
Jan 6, 2016
Complete features of ScrollableList2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements the remaining missing features of ScrollableList2.
It should now be nearly a drop-in replacement for ScrollableList. The
next patch will switch callers over to the new machinery.