Skip to content

[platform_view]add android deps to platform view test - #108585

Merged
auto-submit[bot] merged 1 commit into
masterfrom
huan_native_platform_view_ui_tests_ios_remove_device
Jul 28, 2022
Merged

auto-submit[bot] merged 1 commit into
masterfrom
huan_native_platform_view_ui_tests_ios_remove_device

Conversation

@hellohuanlin

@hellohuanlin hellohuanlin commented Jul 28, 2022 •

Copy link
Copy Markdown
Contributor

deviceOperatingSystem = .ios does not work because it's asking for ios device.

if we do not set deviceOperatingSystem = .ios; then deviceOperatingSystem is default to use android.

So we will need to add dependencies to android.

List which issues are fixed by this PR. You must list at least one issue.

#106745 (comment)

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin
hellohuanlin requested a review from keyonghan as a code owner July 28, 2022 22:43
@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 28, 2022
@hellohuanlin
hellohuanlin requested a review from jmagman July 28, 2022 22:43

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants