[dap] Don't wait for appStarted before responding to launch/attach + don't call app.stop for unstarted app - #109386

Working on the test failures, and a little bit more cleanup, so changing this back to Draft..

Edit: Apparently I can't.. I'll ping when it's ready again.

@christopherfujino ok, it's good now. There was a method _connectDebuggerIfReady that was called in two places, and would only connect the debugger if both of the other methods had received their respective events. This was a bit clumsy, so now the the ifReady is gone and we only ever call that method in one place, and just await the other event before we do.

You are having windows build_tests failing can we address those?

@christopherfujino do you know what's wrong with that build? I'm not sure if I'm looking at the right part of the log, but I see some failures like this:

[+4088 ms] > Configure project :app
[        ] Evaluating project ':app' using build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle'.
[        ] Compiling build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle' using SubsetScriptTransformer.
[        ] Compiling build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle' using BuildScriptTransformer.
[   +1 ms] FAILURE: Build failed with an exception.
[   +2 ms] * Where:
[        ] Script 'C:\b\s\w\ir\x\w\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 293
[        ] * What went wrong:
[        ] A problem occurred evaluating script.
[        ] > Failed to apply plugin class 'FlutterPlugin'.
[        ]    > Comparison method violates its general contract!
[        ] * Try:
[        ] > Run with --debug option to get more log output.
[        ] > Run with --scan to get full insights.
[        ] * Exception is:
[        ] org.gradle.api.GradleScriptException: A problem occurred evaluating script.
[        ] 	at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:93)
[        ] 	at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.lambda$apply$0(DefaultScriptPluginFactory.java:133)
[        ] 	at org.gradle.configuration.DefaultScriptTarget.addConfiguration(DefaultScriptTarget.java:74)
[        ] 	at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.apply(DefaultScriptPluginFactory.java:136)
[        ] 	at org.gradle.configuration.BuildOperationScriptPlugin$1.run(BuildOperationScriptPlugin.java:65)
[        ] 	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
[        ] 	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)

If I'm understanding the log correctly, this might be a test unrelated to this PR:

Testing APK build for examples\platform_channel...
▌12:49:37▐ RUNNING: cd examples\platform_channel; ..\..\bin\flutter.bat build apk --debug -v

@christopherfujino do you know what's wrong with that build? I'm not sure if I'm looking at the right part of the log, but I see some failures like this:

[+4088 ms] > Configure project :app
[        ] Evaluating project ':app' using build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle'.
[        ] Compiling build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle' using SubsetScriptTransformer.
[        ] Compiling build file 'C:\b\s\w\ir\x\w\flutter\examples\platform_channel\android\app\build.gradle' using BuildScriptTransformer.
[   +1 ms] FAILURE: Build failed with an exception.
[   +2 ms] * Where:
[        ] Script 'C:\b\s\w\ir\x\w\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 293
[        ] * What went wrong:
[        ] A problem occurred evaluating script.
[        ] > Failed to apply plugin class 'FlutterPlugin'.
[        ]    > Comparison method violates its general contract!
[        ] * Try:
[        ] > Run with --debug option to get more log output.
[        ] > Run with --scan to get full insights.
[        ] * Exception is:
[        ] org.gradle.api.GradleScriptException: A problem occurred evaluating script.
[        ] 	at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:93)
[        ] 	at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.lambda$apply$0(DefaultScriptPluginFactory.java:133)
[        ] 	at org.gradle.configuration.DefaultScriptTarget.addConfiguration(DefaultScriptTarget.java:74)
[        ] 	at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.apply(DefaultScriptPluginFactory.java:136)
[        ] 	at org.gradle.configuration.BuildOperationScriptPlugin$1.run(BuildOperationScriptPlugin.java:65)
[        ] 	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
[        ] 	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)

If I'm understanding the log correctly, this might be a test unrelated to this PR:

Testing APK build for examples\platform_channel...
▌12:49:37▐ RUNNING: cd examples\platform_channel; ..\..\bin\flutter.bat build apk --debug -v

I've been out of office for a week and a half, so I don't recognize this, however I'm 99% sure it's unrelated to this PR. I'd try rebasing upstream.

Looks that fixed it, thanks!