Skip to content

Add Overlay.maybeOf, make Overlay.of return a non-nullable instance - #110811

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gspencergoog:overlay_maybe_of
Sep 2, 2022
Merged

Add Overlay.maybeOf, make Overlay.of return a non-nullable instance#110811
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gspencergoog:overlay_maybe_of

Conversation

@gspencergoog

@gspencergoog gspencergoog commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Description

Adds Overlay.maybeOf and makes Overlay.of return a non-nullable instance. This was missed when we did our non-nullable by default migrations.

Tests

  • Added a test of maybeOf, updated the of test.

@flutter-dashboard flutter-dashboard Bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 1, 2022
@gspencergoog gspencergoog changed the title Add Overlay.maybeOf, make Overlay.of non-nullable Add Overlay.maybeOf, make Overlay.of return a non-nullable instance Sep 1, 2022
@goderbauer

goderbauer commented Sep 1, 2022

Copy link
Copy Markdown
Member

Looks like the analyzer is not happy.

goderbauer
goderbauer approved these changes Sep 1, 2022
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/widgets/overlay.dart Outdated
Comment thread packages/flutter/lib/src/widgets/overlay.dart
Comment thread packages/flutter/lib/src/widgets/overlay.dart
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2022
@auto-submit
auto-submit Bot merged commit 2051f09 into flutter:master Sep 2, 2022
@gspencergoog
gspencergoog deleted the overlay_maybe_of branch September 2, 2022 00:13
This was referenced Sep 2, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
2e79a53 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
f92d041 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
4e57978 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
5850eac 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
be2231b 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
6a0256e 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
dafdbdc 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
d04a5b2 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
327d23b 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
402aeba 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
61bc450 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
a50f069 
…e instance (flutter/flutter#110811)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
2265843 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
31cc22c 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
bd8d081 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
f4b6405 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
4c5e5a0 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
bee0781 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
28a4267 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
8752750 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
4ebccd4 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
073bb44 
…e instance (flutter/flutter#110811)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
2051f09 Add Overlay.maybeOf, make Overlay.of return a non-nullabl…
d455027 
…e instance (flutter/flutter#110811)
@rydmike rydmike mentioned this pull request Jan 30, 2023
Closed
rydmike added a commit to rydmike/website that referenced this pull request Jan 31, 2023
@rydmike
Add Overlay.of to 3.7 breaking changes
d9c1fcb 
The `Overlay.of` breaking change is missing in 3.7 breaking changes doc page. It was done in a separate PR flutter/flutter#110811 earlier than the bulk of the other changes in flutter/flutter#114120
@rydmike rydmike mentioned this pull request Jan 31, 2023
Merged
3 tasks done
sfshaza2 pushed a commit to flutter/website that referenced this pull request Jan 31, 2023
@rydmike
Add Overlay.of to 3.7 breaking changes (#8188)
76deba5 
The `Overlay.of` breaking change is missing in 3.7 breaking changes doc page. It was done in a separate PR flutter/flutter#110811 earlier than the bulk of the other changes in flutter/flutter#114120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gspencergoog @goderbauer