Skip to content

Deprecate ThemeData.bottomAppBarColor - #111080

Merged
esouthren merged 14 commits into
flutter:masterfrom
esouthren:bottomappbarcolor
Sep 8, 2022
Merged

esouthren merged 14 commits into
flutter:masterfrom
esouthren:bottomappbarcolor

Conversation

@esouthren

Copy link
Copy Markdown
Contributor

Related: #91772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Sep 7, 2022
Comment thread packages/flutter/test/material/bottom_app_bar_test.dart Outdated
Comment thread packages/flutter/lib/src/material/theme_data.dart Outdated
Comment thread packages/flutter/lib/fix_data.yaml
@esouthren
esouthren marked this pull request as ready for review September 8, 2022 09:06
@esouthren
esouthren requested a review from guidezpl September 8, 2022 09:07

@guidezpl guidezpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one bits the dust!

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

XilaiZhang added a commit that referenced this pull request Sep 8, 2022
@HansMuller HansMuller changed the title Deprecate ThemeDate.bottomAppBarColor Deprecate ThemeData.bottomAppBarColor Sep 9, 2022
auto-submit Bot pushed a commit that referenced this pull request Feb 28, 2024
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in #110162.
Part of #111080
auto-submit Bot pushed a commit that referenced this pull request Feb 29, 2024
This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in #97972.
Part of #111080
justinmc pushed a commit to flutter/packages that referenced this pull request Apr 20, 2026
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in flutter/flutter#110162.
Part of flutter/flutter#111080
justinmc pushed a commit to flutter/packages that referenced this pull request Apr 20, 2026
This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in flutter/flutter#97972.
Part of flutter/flutter#111080
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in flutter/flutter#110162.
Part of flutter/flutter#111080
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in flutter/flutter#97972.
Part of flutter/flutter#111080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants