Skip to content

Add support for Material 3 Divider and VerticalDivider - #112655

Merged
darrenaustin merged 1 commit into
flutter:masterfrom
darrenaustin:m3_divider
Sep 29, 2022
Merged

Add support for Material 3 Divider and VerticalDivider#112655
darrenaustin merged 1 commit into
flutter:masterfrom
darrenaustin:m3_divider

Conversation

@darrenaustin

@darrenaustin darrenaustin commented Sep 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a reland of #112378 which had to be reverted due to some golden tests that failed.

Those have been resolved, but wanted to add a few changes to @TahaTesser's PR.

In addition to adding M3 Divider support, this also adds M3 support for the Divider.createBorderSide function.

Thanks @TahaTesser for the original work on this!

Fixes: #112169

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 29, 2022
@darrenaustin
darrenaustin marked this pull request as ready for review September 29, 2022 17:50
@darrenaustin darrenaustin mentioned this pull request Sep 29, 2022
Merged
HansMuller
HansMuller approved these changes Sep 29, 2022
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TahaTesser
TahaTesser approved these changes Sep 29, 2022
View reviewed changes

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin
darrenaustin merged commit 2bf83dd into flutter:master Sep 29, 2022
@darrenaustin
darrenaustin deleted the m3_divider branch September 29, 2022 18:30
This was referenced Sep 30, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
2bf83dd Add support for Material 3 Divider and VerticalDivider (flutt…
20106e1 
…er/flutter#112655)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
2bf83dd Add support for Material 3 Divider and VerticalDivider (flutt…
9bcefa1 
…er/flutter#112655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl Awaiting requested review from guidezpl
2 more reviewers
@HansMuller HansMuller HansMuller approved these changes
@TahaTesser TahaTesser TahaTesser approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Divider to support Material 3

3 participants

@darrenaustin @HansMuller @TahaTesser