Skip to content

Fix: Cannot scroll in DataTable documentation example (#112755) - #113194

Closed
ferndot wants to merge 1 commit into
flutter:masterfrom
ferndot:issue-112755
Closed

Fix: Cannot scroll in DataTable documentation example (#112755)#113194
ferndot wants to merge 1 commit into
flutter:masterfrom
ferndot:issue-112755

Conversation

@ferndot

@ferndot ferndot commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown

This PR converts the SizedBox in the second DataTable documentation example to a SingleChildScrollView, allowing the user to scroll to see items outside the viewport.

Fixes: #112755

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
    Is this test-exempt? I did not see any existing tests for this example.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 10, 2022
@flutter-dashboard

flutter-dashboard Bot commented Oct 10, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ferndot ferndot mentioned this pull request Oct 10, 2022
Closed
@ferndot

ferndot commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

I am looking into creating a test case for the scroll functionality. Any feedback on this or whether it is necessary would be lovely!

@gspencergoog

gspencergoog commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Yes, this will need a test case, since examples are tested just like regular code.

@TahaTesser

TahaTesser commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

@ferndot
Are you still working on this?

@ferndot

ferndot commented Feb 6, 2023

Copy link
Copy Markdown
Author

@TahaTesser I apologize for the delay. I have been pretty busy and have not had a chance to look at this again. Feel free to take it.

@TahaTesser

TahaTesser commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

@ferndot
No worries, closing this for lack of test.

@TahaTesser TahaTesser closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot scroll in DataTable documentation example

4 participants

@ferndot @gspencergoog @TahaTesser @atsansone