Repository navigation
Cannot scroll in DataTable documentation example #112755
Description
Activity
- addedin triagePresently being triaged by the triage teamPresently being triaged by the triage teamframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packagesd: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/and removedin triagePresently being triaged by the triage teamPresently being triaged by the triage team
on Oct 3, 2022 I have a proposed fix for this over in #113194
Can i fix this issue
- addedteam-designOwned by Design Languages teamOwned by Design Languages teamtriaged-designTriaged by Design Languages teamTriaged by Design Languages team
on Jul 8, 2023 1 remaining item
I would like to work on this. I understand this PR just requires some tests or is there something more to do as well?
Take a look at #113194. Just need a small test to check datatable is scrollable and the fix should be good to go.
So it's just a test which does drag + checks if the item below are visible? Or something more too?
So it's just a test which does drag + checks if the item below are visible? Or something more too?
Yes, just scroll to update the visible items. We'll also need to document the performance implications of SinglleChildScrollView with DataTable. If you're not sure, I can find another issue for you.
Any place you would suggest me to figure out the performance implications? I'd like to dig through it instead of an easier bug @TahaTesser
Any place you would suggest me to figure out the performance implications? I'd like to dig through it instead of an easier bug @TahaTesser
Look at the "Performance considerations" section at https://master-api.flutter.dev/flutter/material/ListTile-class.html.
We just need a similar description for using
SingleChildScrollViewon aDataTablewith a large number of rows. No extra code example is needed.cc: @Piinks
Reacted by Kate Lovett, Chinmay Kabi and Sudhansu Bhushan MishraI am working on the test. One issue I faced is that because the list is too small, all the items are already visible on the screen.So the initial assertion of first item being visible and last not being visible cannot be made. I can either
- Increase the list count (Works with list size 20)
- Set a surface size for the test to run
What should be the approach here?
I am proceeding with increasing the list count for now, will change if necessary
Hey,
I am interested to solve this. Can you please assign me this task?@Anianonymous
Please see the linked PR above , this is being fixed.
You can search for similar issues in the Flutter repository.
The example has 10 rows, but you can't scroll to the rows out of view. Scrolling isn't the point of the example, but there are rows out of view and showing scrolling would be helpful for less experienced users.
https://api.flutter.dev/flutter/material/DataTable-class.html#material.DataTable.2
https://api.flutter.dev/flutter/material/DataTable-class.html#material.DataTable.2
I initialized value as numItems as 100 I can scroll down easily and I wrapped the SizedBox with SingleChildScrollView.
I hope that I've solved your issue @jibbers42- addedr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
on Sep 12, 2023 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Sep 26, 2023
The example has 10 rows, but you can't scroll to the rows out of view. Scrolling isn't the point of the example, but there are rows out of view and showing scrolling would be helpful for less experienced users.
https://api.flutter.dev/flutter/material/DataTable-class.html#material.DataTable.2