Skip to content

Added backgroundColor and disabledBackgroundColor to SnackBarAction. - #118786

Merged
HansMuller merged 1 commit into
flutter:masterfrom
chinmoy12c:issue_109933
Mar 27, 2023
Merged

HansMuller merged 1 commit into
flutter:masterfrom
chinmoy12c:issue_109933

Conversation

@chinmoy12c

Copy link
Copy Markdown
Member

This PR adds backgroundColor and disabledBackgroundColor properties to SnackBarAction.

Fixes: #109933

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2023
@HansMuller
HansMuller self-requested a review January 20, 2023 20:05
@chinmoy12c

Copy link
Copy Markdown
Member Author

@HansMuller could you please review this?

@HansMuller
HansMuller requested a review from esouthren February 21, 2023 17:18

@esouthren esouthren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chinmoy12c, thanks for your patience on the review.

Mostly LGTM; some small comments.

Comment thread packages/flutter/lib/src/material/snack_bar.dart Outdated
Comment thread packages/flutter/test/material/snack_bar_test.dart Outdated
@chinmoy12c

Copy link
Copy Markdown
Member Author

Hey @esouthren sorry for the delay, made the changes :)

@chinmoy12c
chinmoy12c requested review from esouthren and removed request for HansMuller March 27, 2023 07:19

@esouthren esouthren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller
HansMuller merged commit aa5db20 into flutter:master Mar 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@reidbaker reidbaker mentioned this pull request Mar 28, 2023
8 tasks done
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to set background color of SnackBarAction when clicked

3 participants