Skip to content

ShaderMask needs to play nicely with compositing - #1192

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:composite_shader_mask
Jan 12, 2016
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:composite_shader_mask

Conversation

@abarth

@abarth abarth commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

This patch adds ShaderLayer and makes ShaderMask use it.

Fixes #1155

@abarth abarth changed the title RenderPerformanceOverlay needs alwaysNeedsCompositing ShaderMask needs to play nicely with compositing Jan 11, 2016
@abarth

abarth commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

@Hixie @chinmaygarde

Needs engine roll before landing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment lies!

@Hixie

Hixie commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

lgtm

@abarth
abarth force-pushed the composite_shader_mask branch 4 times, most recently from cebd41f to fbf7587 Compare January 12, 2016 00:48
@abarth abarth added the engine flutter/engine related. See also e: labels. label Jan 12, 2016
This patch adds ShaderLayer and makes ShaderMask use it.

Fixes flutter#1155
@abarth
abarth force-pushed the composite_shader_mask branch from fbf7587 to 82bb3bd Compare January 12, 2016 05:58
abarth added a commit that referenced this pull request Jan 12, 2016
ShaderMask needs to play nicely with compositing
@abarth
abarth merged commit a2f7bb7 into flutter:master Jan 12, 2016
@abarth
abarth deleted the composite_shader_mask branch January 12, 2016 06:06
TahaTesser pushed a commit to NevercodeHQ/flutter that referenced this pull request Aug 13, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShaderMask needs to play nicely with compositing

2 participants