Skip to content

Fix Material3 TabBarTheme.dividerColor not working - #119690

Merged
auto-submit[bot] merged 9 commits into
flutter:masterfrom
xuelongqy:master
Feb 23, 2023
Merged

Fix Material3 TabBarTheme.dividerColor not working#119690
auto-submit[bot] merged 9 commits into
flutter:masterfrom
xuelongqy:master

Conversation

@xuelongqy

@xuelongqy xuelongqy commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Getting TabBarTheme.dividerColor to work when using Material3.

  • Fix Material3 TabBarTheme.dividerColor not working.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Feb 1, 2023
@flutter-dashboard

flutter-dashboard Bot commented Feb 1, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer

goderbauer commented Feb 2, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution. Can you please add a test?

@xuelongqy

xuelongqy commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution. Can you please add a test?

I have added test. What finally changes is the parameter of _IndicatorPainter, I don't know if casting it to dynamic type is the right way.

@HansMuller
HansMuller self-requested a review February 16, 2023 01:36
HansMuller
HansMuller approved these changes Feb 21, 2023
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit

auto-submit Bot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 119690, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submit Bot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 119690, due to Validations Fail.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit
auto-submit Bot merged commit 156c661 into flutter:master Feb 23, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
da19ed0 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
204691e 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
0d923b4 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
0f709e1 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
19f1312 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
3d31ba3 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
3d149a0 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
1222edb 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
651c947 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
63649b2 
…lutter#119690)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
8ac8620 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
e13fa4e 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
48c4d83 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
226689e 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
0a581c5 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
178a9dc 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
e664c86 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
243aa94 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
c52442d 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
bc1e7d9 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
ecf085b 
…lutter#119690)
@HansMuller HansMuller mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
cc886b6 
…lutter#119690)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
156c661 Fix Material3 TabBarTheme.dividerColor not working (flutter/f…
8df7243 
…lutter#119690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes
+1 more reviewer
@HansMuller HansMuller HansMuller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuelongqy @goderbauer @cbracken @HansMuller @Piinks