Repository navigation
Prepare for adding values to AppLifecycleState - #119954
Conversation
flutter-dashboard
Bot
added
a: text input
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
|
(triage): Should this get submitted or is it waiting on something? |
|
I was waiting until I was a little closer to landing the engine change, to reduce the amount of time that the default clauses were out there before they were replaced. |
f8491f3 to
9134276
Compare
9134276 to
7433ae9
Compare
gspencergoog
added
the
autosubmit
Prepare for adding values to AppLifecycleState
3 participants
Description
This adds necessary default cases to two switch statements that look at
AppLifecycleState. The defaults need to be added temporarily so that a new statehiddencan be added to the engine side without breaking the framework build. Thedefault:s will be removed once those new states are available.See this design doc for more information.
Related Issues
Tests