Skip to content

Fix the maths for floating pinned app bars. - #11996

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:slivers
Sep 13, 2017
Merged

Hixie merged 1 commit into
flutter:masterfrom
Hixie:slivers

Conversation

@Hixie

@Hixie Hixie commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@nonameden

nonameden commented Sep 8, 2017 •

Copy link
Copy Markdown

@Hixie as far as I remember RenderSliverFloatingPersistentHeader has same issue as RenderSliverFloatingPinnedPersistentHeader

Please let me know if you need more info or sample to reproduce that issue

@Hixie

Hixie commented Sep 8, 2017

Copy link
Copy Markdown
Contributor Author

I couldn't find an equivalent error in RenderSliverFloatingPersistentHeader. If you have an example that would be very useful.

@nonameden

Copy link
Copy Markdown

I have checked with latest version of Flutter, looks like there was some changes since my PR. changing maxExtent to minExtent in render class does not affect NestedScrollView anymore.

Please use Gist from @HansMuller for testing: https://gist.github.com/HansMuller/facae02ce97892eaa2f159ea50c45e61

Issue easy to replicate with floating: true, pinned: true and floating: false, pinned: true for sliver app bar inside NestedScrollView

@Hixie

Hixie commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

@nonameden I don't really understand that issue. Can you file a bug for it? Then we can handle it separately.

@nonameden

Copy link
Copy Markdown

Already did: #11222
Just to clear on issue: inside the page we have a container with text 1 Header - during a scroll it should not scroll under the pinned action bar.

@Hixie

Hixie commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

#11222

Great, thanks. That looks like a separate issue.

@nonameden

Copy link
Copy Markdown

Yep, but before it was fixable with minExtent in renderer, because scroller in NestedScrollView was using it to calculate scroll range for outer scroll

@HansMuller

Copy link
Copy Markdown
Contributor

LGTM

@Hixie
Hixie merged commit da0602f into flutter:master Sep 13, 2017
@Hixie
Hixie deleted the slivers branch September 13, 2017 16:30
Hixie added a commit that referenced this pull request Sep 13, 2017
Hixie added a commit that referenced this pull request Sep 13, 2017
Hixie added a commit to Hixie/flutter that referenced this pull request Sep 14, 2017
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants