Skip to content

CP: fix crash during flutter doctor --android-licenses - #120717

Merged
itsjustkevin merged 4 commits into
flutter:flutter-3.7-candidate.1from
chris-forks:flutter-3.7-candidate.1
Feb 28, 2023
Merged

itsjustkevin merged 4 commits into
flutter:flutter-3.7-candidate.1from
chris-forks:flutter-3.7-candidate.1

Conversation

@christopherfujino

Copy link
Copy Markdown
Contributor

Cherrypick of b8f5394

and

1546fa0

To fix #114031 on the stable branch.

…ndroid-licenses (flutter#119977)

* wip

* write test

* make error handling printError

* remove diff
…icenses (flutter#120330)

* tool exit on sdk manager exit and add test

* be more specific about error message
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 14, 2023
@christopherfujino christopherfujino changed the title Flutter 3.7 candidate.1 CP: fix crash during flutter doctor --android-licenses Feb 14, 2023

@Jasguerrero Jasguerrero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ammarbajwa19

This comment was marked as off-topic.

@itsjustkevin
itsjustkevin merged commit e863516 into flutter:flutter-3.7-candidate.1 Feb 28, 2023
@christopherfujino
christopherfujino deleted the flutter-3.7-candidate.1 branch February 28, 2023 21:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants