Skip to content

Remove single axis assertion from GlowingOverscrollIndicator - #120738

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:glowAssert
Feb 21, 2023
Merged

Remove single axis assertion from GlowingOverscrollIndicator#120738
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:glowAssert

Conversation

@Piinks

@Piinks Piinks commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Fixes #120735

2D Scrolling proposal: flutter.dev/go/2D-Foundation

In preparation for 2D scrolling, this removes an assertion from the GlowingOverscrollIndicator when it receives a notification from another axis. It is already configured to only apply in one axis, and so now it will just do nothing.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 15, 2023
@Piinks
Piinks requested a review from guidezpl February 17, 2023 19:42
guidezpl
guidezpl approved these changes Feb 20, 2023
View reviewed changes

@guidezpl guidezpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@Piinks Piinks added p: material_ui material_ui package in flutter/packages autosubmit Merge PR when tree becomes green via auto submit App labels Feb 21, 2023
@auto-submit
auto-submit Bot merged commit 09518ac into flutter:master Feb 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
09518ac72 Remove single axis assertion (flutter/flutter#120738)
7b951d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
09518ac72 Remove single axis assertion (flutter/flutter#120738)
3240e34
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
09518ac72 Remove single axis assertion (flutter/flutter#120738)
8e3b2c1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
09abb32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
401fbea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
4da2644
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
508d969
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
e63ddc0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
42e3485
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
0b6062a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
b280017
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
fbee97d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
c1bde0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
3669fc9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
cbd9f97
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
9804ca8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
665d3c6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
d1c1d44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
6fcc0c8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
16ab74b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
25e4dc6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
8a2287f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
b081ca5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
798856d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
54150a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
4ab67fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
605daf1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
2941425
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
09518ac Remove single axis assertion (flutter/flutter#120738)
058f084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GlowingOverscrollIndicator asserts against alternate notification axes

2 participants

@Piinks @guidezpl