Skip to content

document StaticIconProvider - #120935

Merged
auto-submit[bot] merged 8 commits into
flutter:masterfrom
chris-forks:document-icon-data
Apr 8, 2023
Merged

document StaticIconProvider#120935
auto-submit[bot] merged 8 commits into
flutter:masterfrom
chris-forks:document-icon-data

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Feb 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #120459

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 17, 2023
@goderbauer

goderbauer commented Feb 28, 2023

Copy link
Copy Markdown
Member

(triage) @christopherfujino Do you still have plans to finish this one up? Would be awesome to have better documentation on this!

@christopherfujino

christopherfujino commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

(triage) @christopherfujino Do you still have plans to finish this one up? Would be awesome to have better documentation on this!

Yup, thanks for the ping!

@christopherfujino

christopherfujino commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

ping @christopherfujino please land this.

@christopherfujino
christopherfujino marked this pull request as ready for review March 21, 2023 23:48
@christopherfujino

christopherfujino commented Mar 23, 2023

Copy link
Copy Markdown
Contributor Author

@goderbauer this is my first framework doc PR, does this align with our style?

goderbauer
goderbauer reviewed Mar 23, 2023
View reviewed changes
Comment thread packages/flutter/lib/src/widgets/icon_data.dart Outdated
Comment thread packages/flutter/lib/src/widgets/icon_data.dart Outdated
Comment on lines 112 to 113

@goderbauer goderbauer Mar 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would rephrase this, instead of saying "should" I would say, tree shaking only works if you do this. Otherwise your binary will be larger than necessary (or whatever the failure mode is).

@christopherfujino christopherfujino Apr 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, WDYT?

goderbauer
goderbauer approved these changes Apr 7, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/widgets/icon_data.dart Outdated
christopherfujino
christopherfujino commented Apr 7, 2023
View reviewed changes
Comment thread packages/flutter/lib/src/widgets/icon_data.dart Outdated
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit
auto-submit Bot merged commit 3ea2d72 into flutter:master Apr 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2023
@engine-flutter-autoroll
3ea2d72 document StaticIconProvider (flutter/flutter#120935)
3d467b2
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@christopherfujino @exaby73
document StaticIconProvider (flutter#120935)
53f507c 
document StaticIconProvider
@slavap

slavap commented Jul 25, 2023

Copy link
Copy Markdown

Reading comment added for StaticIconProvider still does not answer the question - "How to make tree shaking working for custom font?". I have custom icon font added to assests and declared:

@staticIconProvider
abstract final class MyIcons { ... }

but don't see tree shaking works for my custom font. What should I do to make it work?

@christopherfujino
christopherfujino deleted the document-icon-data branch July 25, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document the @staticIconProvider annotation in the IconData class dartdoc

3 participants

@christopherfujino @goderbauer @slavap