Repository navigation
Add support for application exit requests - #121378
Merged
Merged
Conversation
gspencergoog
force-pushed
the
application_exit
branch
from
February 24, 2023 03:54
c0312eb to
b925bfc
Compare
gspencergoog
force-pushed
the
application_exit
branch
3 times, most recently
from
February 27, 2023 23:51
c84dfab to
b8a77ae
Compare
gspencergoog
force-pushed
the
application_exit
branch
2 times, most recently
from
March 3, 2023 19:29
8a6f4b2 to
613a839
Compare
gspencergoog
commented
Mar 3, 2023
gspencergoog
force-pushed
the
application_exit
branch
from
March 6, 2023 16:25
b66a893 to
753a64c
Compare
gspencergoog
force-pushed
the
application_exit
branch
4 times, most recently
from
March 7, 2023 20:48
31952bf to
a685df2
Compare
gspencergoog
force-pushed
the
application_exit
branch
from
March 7, 2023 21:21
21b9f91 to
adc982d
Compare
gspencergoog
marked this pull request as ready for review
March 7, 2023 21:21
Contributor
Author
|
Okay, I think this is ready for a review. |
robert-ancell
approved these changes
Mar 8, 2023
robert-ancell
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Note the CI seems to have failed due to some trivial formatting issues.
goderbauer
reviewed
Mar 8, 2023
goderbauer
reviewed
Mar 8, 2023
gspencergoog
force-pushed
the
application_exit
branch
from
March 13, 2023 23:28
898e414 to
b3fc1bb
Compare
gspencergoog
force-pushed
the
application_exit
branch
from
March 17, 2023 05:42
380347e to
76a4f98
Compare
Contributor
|
auto label is removed for flutter/flutter, pr: 121378, due to - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for handling an application exit request from the engine.
Related PRs
System.exitApplicationandSystem.requestAppExitsupport flutter-team-archive/engine#39836Related Issues
Tests