Skip to content

Revert "Add visual density for menu default style" - #121810

Merged
QuncCccccc merged 1 commit into
masterfrom
revert-114878-add_visualDensity_for_menu_default_style
Mar 2, 2023
Merged

QuncCccccc merged 1 commit into
masterfrom
revert-114878-add_visualDensity_for_menu_default_style

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Mar 2, 2023 •

Copy link
Copy Markdown
Contributor

Reverts #114878

The reverted PR causes a Scuba failure on b/271378386. Will try a re-land later!

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 2, 2023

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For future archeologists: Can you add the reason for the revert to the PR description please.

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esouthren esouthren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc

Copy link
Copy Markdown
Contributor Author

LGTM

For future archeologists: Can you add the reason for the revert to the PR description please.

Just updated! Thanks:)

@QuncCccccc
QuncCccccc merged commit c7fa8e5 into master Mar 2, 2023
@QuncCccccc
QuncCccccc deleted the revert-114878-add_visualDensity_for_menu_default_style branch March 2, 2023 18:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants