Skip to content

[flutter roll] Revert "Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack" - #121835

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-121408-fix-animated-switcher-duplicate-keys
Mar 2, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
revert-121408-fix-animated-switcher-duplicate-keys

Conversation

@XilaiZhang

@XilaiZhang XilaiZhang commented Mar 2, 2023 •

Copy link
Copy Markdown
Contributor

Reverts #121408

I created a tracking bug with scuba links in b/271479418

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 2, 2023
@christopherfujino
christopherfujino removed their request for review March 2, 2023 22:59

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 2, 2023
@auto-submit
auto-submit Bot merged commit 9cb7a15 into master Mar 2, 2023
@auto-submit
auto-submit Bot deleted the revert-121408-fix-animated-switcher-duplicate-keys branch March 2, 2023 23:24
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Mar 2, 2023
… Stack (flutter#121408)" (flutter#121835)

[flutter roll] Revert "Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack"
XilaiZhang added a commit that referenced this pull request Mar 3, 2023
… Stack (#121408)" (#121835) (#121840)

[flutter roll] Revert "Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack"
@jimgerth

jimgerth commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Hi, I was wondering why #121408 got reverted? I‘m not sure I understand the problem.
Is there anything I can do to get this relanded?

@goderbauer

Copy link
Copy Markdown
Member

@jimgerth This is gonna be a little frustrating and I apologize in advance for that: The change was breaking a number of google-internal apps. Unfortunately, I can't give you access to the failing tests. I still believe that your change is the correct one to make. However, until someone with access to google-internal systems can take a look and figure out why these tests are failing we can't make the change. I'll see if I can find someone who can take a look at this.

@jimgerth

jimgerth commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

@goderbauer Alright, thanks for the response. If I can't do anything about it, I can remove it from the back of my mind at least :D

@jimgerth

Copy link
Copy Markdown
Contributor

@goderbauer Are there updates on this by any chance?

@jimgerth

Copy link
Copy Markdown
Contributor

@goderbauer Has anyone looked at this in the past month?

@gnprice

gnprice commented Apr 19, 2023

Copy link
Copy Markdown
Member

@jimgerth Another place you might try is in Discord:
https://github.com/flutter/flutter/wiki/Chat
I think the #hackers-framework channel would be appropriate.

You can ask there if someone can help you land a bugfix that needs help resolving some Google internal tests.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants