Skip to content

ModalBottomSheetRoute: Remove gap at screen bottom with useSafeArea: true - #122118

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
chrisbobbe:pr-bottom-sheet-remove-gap
Mar 8, 2023
Merged

ModalBottomSheetRoute: Remove gap at screen bottom with useSafeArea: true#122118
auto-submit[bot] merged 1 commit into
flutter:masterfrom
chrisbobbe:pr-bottom-sheet-remove-gap

Conversation

@chrisbobbe

@chrisbobbe chrisbobbe commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #121554.

With useSafeArea: true, the added SafeArea now has bottom: false, to prevent a gap from appearing between the bottom edge of the sheet and the bottom edge of the screen, across the system intrusion there.

The useSafeArea: false case still has a bug not addressed here; that's #121752. I plan to submit a separate fix for that.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2023
@chrisbobbe chrisbobbe mentioned this pull request Mar 7, 2023
Closed
8 tasks done
gnprice
gnprice approved these changes Mar 7, 2023
View reviewed changes

@gnprice gnprice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

hannah-hyj
hannah-hyj approved these changes Mar 7, 2023
View reviewed changes

@hannah-hyj hannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnprice gnprice added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@chrisbobbe @gnprice
ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea:…
e10cd03 
… true`

Fixes flutter#121554.

With `useSafeArea: true`, the added `SafeArea` now has
`bottom: false`, to prevent a gap from appearing between the bottom
edge of the sheet and the bottom edge of the screen, across the
system intrusion there.

The `useSafeArea: false` case still has a bug not addressed here;
that's flutter#121752. I plan to submit a separate fix for that.
@gnprice
gnprice force-pushed the pr-bottom-sheet-remove-gap branch from 39e73ee to e10cd03 Compare March 8, 2023 02:29
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit

auto-submit Bot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 122118, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gnprice

gnprice commented Mar 8, 2023

Copy link
Copy Markdown
Member

@Hangyujin Would you take a look at the Google testing failure? This PR was only touching the useSafeArea: true case, but it seems something still broke with that.

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@hannah-hyj

hannah-hyj commented Mar 8, 2023

Copy link
Copy Markdown
Member

@gnprice The google testing failure is expected and manually approved.

@gnprice

gnprice commented Mar 8, 2023

Copy link
Copy Markdown
Member

Excellent. Thanks for your help!

@auto-submit
auto-submit Bot merged commit 23b7bbd into flutter:master Mar 8, 2023
@chrisbobbe
chrisbobbe deleted the pr-bottom-sheet-remove-gap branch March 8, 2023 19:42
@chrisbobbe chrisbobbe mentioned this pull request Mar 8, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
6eae6e2 
…afeArea: true` (flutter/flutter#122118)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
3b32387 
…afeArea: true` (flutter/flutter#122118)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
843186c 
…afeArea: true` (flutter/flutter#122118)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
839182f 
…afeArea: true` (flutter/flutter#122118)
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this pull request Mar 10, 2023
@chrisbobbe
deps: Bump Flutter / Dart SDK floors to latest
84ebc01 
This gets us flutter/flutter@23b7bbd89 (flutter/flutter#122118),
which we'll use to make a nice prototype for the message action
sheet, coming soon.
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
@chrisbobbe @hannah-hyj
ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea:…
95f70dd 
… true` (flutter#122118)

ModalBottomSheetRoute: Remove gap at screen bottom with `useSafeArea: true`
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
f6789e4 
…afeArea: true` (flutter/flutter#122118)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
9384786 
…afeArea: true` (flutter/flutter#122118)
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
cd06a7a 
…afeArea: true` (flutter/flutter#122118)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
23b7bbd ModalBottomSheetRoute: Remove gap at screen bottom with `useS…
8d34b44 
…afeArea: true` (flutter/flutter#122118)
@gnprice gnprice mentioned this pull request Jun 27, 2023
Closed
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnprice gnprice gnprice approved these changes
@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModalBottomSheetRoute: useSafeArea puts gap below sheet

3 participants

@chrisbobbe @gnprice @hannah-hyj