Repository navigation
DateRangePicker keyboardType - #122353
Merged
Merged
DateRangePicker keyboardType#122353
Conversation
flutter-dashboard
Bot
added
p: material_ui
justinmc
force-pushed
the
date-range-picker-keyboard
branch
from
March 10, 2023 01:04
b6f2ef0 to
ec3a95a
Compare
justinmc
marked this pull request as ready for review
March 10, 2023 18:14
Renzo-Olivares
approved these changes
Mar 14, 2023
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I wonder if we want to limit the set of TextInputType that DateRangePicker supports. Is there any TextInputType that doesn't make sense in the context of DateRangePicker?
LongCatIsLooong
approved these changes
Mar 14, 2023
Contributor
Author
|
@Renzo-Olivares Good point, it would be weird to use the If you have a specific idea let me know though. |
Contributor
Author
|
Google testing appears stuck for the last several days, but it shouldn't be a problem. Merging. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
keyboardTypeparameter to DateRangePicker.Fixes #121912.