Skip to content

Reland "Remove references to BindingBase.window (#122119 & #122341)" - #122412

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
goderbauer:reland
Mar 14, 2023
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
goderbauer:reland

Conversation

@goderbauer

@goderbauer goderbauer commented Mar 10, 2023 •

Copy link
Copy Markdown
Member

Relands #122119.
Relands #122341.

Partial revert of #122369.

Blocked on reland of #122233.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages f: gestures flutter/packages/flutter/gestures repository. p: material_ui material_ui package in flutter/packages f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 10, 2023
@goderbauer goderbauer changed the title Reland Reland "Remove references to BindingBase.window (#122119 & #122341)" Mar 10, 2023
@goderbauer

Copy link
Copy Markdown
Member Author

Do not submit until #122422 trickled through FROB.

@pdblasi-google pdblasi-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit
auto-submit Bot merged commit 473fa38 into flutter:master Mar 14, 2023
@goderbauer
goderbauer deleted the reland branch March 14, 2023 16:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: gestures flutter/packages/flutter/gestures repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants