Skip to content

[integration_test] upgrade androidx test to 1.4.0 - #122437

Merged
auto-submit[bot] merged 30 commits into
flutter:masterfrom
micaelcid:master
Apr 11, 2023
Merged

[integration_test] upgrade androidx test to 1.4.0#122437
auto-submit[bot] merged 30 commits into
flutter:masterfrom
micaelcid:master

Conversation

@micaelcid

@micaelcid micaelcid commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I just finished migrating a project to Android 13 that runs integration_test with Firebase Test Lab. In this PR, I am changing the exact dependencies I needed to change to make our application able to run integration tests targeting Android 13. (the project is currently depending on my fork).

This PR is being reopened from #109547, adding the pipeline fixes

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 10, 2023
@micaelcid
micaelcid force-pushed the master branch 2 times, most recently from 4332aaf to 646b46b Compare March 10, 2023 23:18
@micaelcid

micaelcid commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

I'm reopening this as a Draft until I solve all CI failures that appeared after merging #109547

The failures can be found here: https://github.com/flutter/flutter/runs/11827814804

@micaelcid
micaelcid marked this pull request as ready for review March 13, 2023 01:41
@micaelcid

micaelcid commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Hey, @ricardoamador. My last PR was reverted, but I guess I solved the other issues now. Would you mind reviewing this again?

@ricardoamador

ricardoamador commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Yes, will do.

@ricardoamador

ricardoamador commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

@micaelcid if you are stuck with IOS you can always try the flutter hackers-ios channel on discord and ask for some help there.

@micaelcid

micaelcid commented Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for letting me know! I'll do that as soon as I've got spare time.

@micaelcid

micaelcid commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

@ricardoamador I didn't do anything, but after rebasing my branch with master that failed MacOS test seems to be solved. Perhaps it was some flakiness that had nothing to do with my changes 🤔

Do you mind reviewing them now, or is it best to wait for the tree to get fixed?

@ricardoamador

ricardoamador commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

I can take a look.

reidbaker
reidbaker requested changes Mar 28, 2023
View reviewed changes
Comment thread dev/benchmarks/complex_layout/android/gradle/wrapper/gradle-wrapper.properties
@micaelcid

micaelcid commented Mar 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hey, @reidbaker. I just solved your requested changes and the pipeline checks have passed. Do you mind reviewing again?

@micaelcid
micaelcid requested review from reidbaker and removed request for zanderso March 30, 2023 14:03
@reidbaker

reidbaker commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Hey, @reidbaker. I just solved your requested changes and the pipeline checks have passed. Do you mind reviewing again?

Yep I will do my best to get to it today if not then by EOD Fri.

@micaelcid

micaelcid commented Mar 30, 2023

Copy link
Copy Markdown
Contributor Author

Are we aware of flaky tests in the GH Actions pipeline? While coming up with this PR, sporadically a few tests would fail and get solved after a rebase. For example, these checks fail intermittently, but they were previously passing.

@micaelcid

micaelcid commented Mar 30, 2023

Copy link
Copy Markdown
Contributor Author

Can you guys @ricardoamador or @reidbaker add the auto-submit label?

@micaelcid

micaelcid commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

Hey, @goderbauer do you mind adding the auto submit label?

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit
auto-submit Bot merged commit 4a83fa0 into flutter:master Apr 11, 2023
zanderso added a commit that referenced this pull request Apr 12, 2023
@zanderso
Revert "[integration_test] upgrade androidx test to 1.4.0 (#122437)"
1989a93 
This reverts commit 4a83fa0.
@zanderso zanderso mentioned this pull request Apr 12, 2023
Merged
zanderso added a commit that referenced this pull request Apr 12, 2023
@zanderso
Revert "[integration_test] upgrade androidx test to 1.4.0" (#124644)
cc2a045 
Reverts #122437

This is causing several Android devicelab tests to fail on the first
attempt, causing them to be marked flaky. The cause appears to be
unexpected output on stderr. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
4a83fa0 [integration_test] upgrade androidx test to 1.4.0 (flutter/fl…
f01fd93 
…utter#122437)
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@micaelcid @exaby73
[integration_test] upgrade androidx test to 1.4.0 (flutter#122437)
635e5b2 
[integration_test] upgrade androidx test to 1.4.0
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@zanderso @exaby73
Revert "[integration_test] upgrade androidx test to 1.4.0" (flutter#1…
6529aa6 
…24644)

Reverts flutter#122437

This is causing several Android devicelab tests to fail on the first
attempt, causing them to be marked flaky. The cause appears to be
unexpected output on stderr. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview
@micaelcid micaelcid mentioned this pull request Mar 11, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes
+1 more reviewer
@ricardoamador ricardoamador ricardoamador approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@micaelcid @ricardoamador @reidbaker